[vtk-developers] Incorrect indentation by vtk_reindent_code.py
Sean McBride
sean at rogue-research.com
Mon Jul 4 17:41:53 EDT 2016
On Mon, 4 Jul 2016 15:57:46 -0400, Bill Lorensen said:
>First, I have mixed emotions about massive changes to fix brace
>spacing. Who benefits? Some developers, yes, the customer, no.
Bill, I take your point, but missing braces and screwed up whitespace can cause real bugs, the most famous recent example being the goto fail bug:
<https://blog.duncanworthy.me/swdev/ios/apple-ssl-goto-fail-bug/>
VTK's Whitesmiths style isn't supported by modern tools, and once we get away from it we can do things like autoformatting, git hooks that reject incorrect formatting, dashboard check of formatting, etc.
See you guys Wednesday!
Cheers,
--
____________________________________________________________
Sean McBride, B. Eng sean at rogue-research.com
Rogue Research www.rogue-research.com
Mac Software Developer Montréal, Québec, Canada
More information about the vtk-developers
mailing list