[vtk-developers] [VTK] Protected methods in vtkDICOMImageReader intended to be public?

Jon Haitz Legarreta jhlegarreta at vicomtech.org
Mon Dec 19 02:39:51 EST 2016


Folks,
I was reviewing the code coverage for vtkDICOMImageReader class.

I've noticed that there are a couple of methods (namely
GetNumberOfDICOMFileNames and GetDICOMFileName) that are not exercised.

However, they are declared as protected, and according to the class doc,
intended to be used in subclasses. But no class inherits from
vtkDICOMImageReader.

Is this OK, or should we make both these methods public?

I guess we can live without testing these methods, but I'm just wondering
whether they were intended to be public.

Thanks,
JON HAITZ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20161219/6e604582/attachment.html>


More information about the vtk-developers mailing list