[vtk-developers] Add GetModifiedTime deprecate GetMTime

[Bill Lorensen]

Brad,

This order?
/* Select a 64-bit integer type.  */
#if VTK_SIZEOF_LONG == 8
typedef unsigned long vtkTypeUInt64;
typedef signed long   vtkTypeInt64;
# define VTK_TYPE_UINT64 VTK_UNSIGNED_LONG
# define VTK_TYPE_INT64 VTK_LONG
#elif VTK_SIZEOF_LONG_LONG == 8
typedef unsigned long long vtkTypeUInt64;
typedef signed long long   vtkTypeInt64;
# define VTK_TYPE_UINT64 VTK_UNSIGNED_LONG_LONG
# define VTK_TYPE_INT64 VTK_LONG_LONG
#else
# error "No native data type can represent a 64-bit integer."
#endif

On Fri, Aug 5, 2016 at 3:57 PM, Robert Maynard
<robert.maynard at kitware.com> wrote:
> +2 to the reorder of vtkTypeUInt64/vtkTypeInt64
>
> On Fri, Aug 5, 2016 at 3:52 PM, Brad King <brad.king at kitware.com> wrote:
>> On 08/05/16 15:45, Bill Lorensen wrote:
>>>
>>> Why not in vtkType.h
>>> #if defined(WIN32)
>>> typedef vtkTypeUInt64 vtkTypeMTime;
>>> #else
>>> typedef unsigned long vtkTypeMTime;
>>> #endif
>>>
>>> In vtkObject.h and other GetMTimes'
>>>   virtual vtkTypeMTime GetMTime();
>>>
>>> Windows apps will have to change their GetMTimes' in their VTK derived
>>> subclasses.
>>
>>
>> With a trivial re-ordering in `Common/Core/vtkType.h` to
>> prefer `long` over `long long` when the former is 64-bit
>> then `vtkTypeUInt64` will be selected as above automatically
>> and can serve this role without a separate typedef.  This
>> would make vtkType.h more consistent anyway.
>>
>> -Brad
>>



-- 
Unpaid intern in BillsBasement at noware dot com