[vtk-developers] ExternalData and regression images

Bill Lorensen bill.lorensen at gmail.com
Thu Apr 14 20:04:55 EDT 2016


For C++ it is pretty easy. Python needs some work...

On Thu, Apr 14, 2016 at 4:34 PM, Will Schroeder
<will.schroeder at kitware.com> wrote:
> +1
>
> The whole external data magic is amazing the way it works, I'd just like to
> make it as easy as possible to add tests and RT images.
>
> On Thu, Apr 14, 2016 at 7:32 PM, Ken Martin <ken.martin at kitware.com> wrote:
>>
>> CTest script/C++ executable maybe for those who do not have python? I have
>> plenty of goats so I'm good, just a thought. :-)
>>
>> On Thu, Apr 14, 2016 at 6:10 PM, Will Schroeder
>> <will.schroeder at kitware.com> wrote:
>>>
>>> IMO the workflow for creating regression test images could be
>>> significantly improved. The incantations require multiple, non-intuitive
>>> steps and on occasions (when things go wrong) the sacraficing of a goat. I'd
>>> really like a simple macro/function (in a python test for example) to create
>>> a regression test image, put it in the right place, and even upload it all
>>> in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would create
>>> a new image if one is not available, otherwise do nothing, etc. And force a
>>> replacement if needed.
>>>
>>> Similarly simple processes for dropping in any alternative _1, _2,
>>> regression test images (cutting and pasting from the dashboard rt images).
>>> And ways to easily recover and move back and forth between md5 and png. I
>>> know some of this is available, but it takes a lot of documentation
>>> digestion to really understand the process which can be hard for newbies or
>>> those who code infrequently. Of most concern I think the process is
>>> cumbersome enough that it discourages adding new tests.
>>>
>>> Best,
>>> W
>>>
>>> On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi <david.gobbi at gmail.com>
>>> wrote:
>>>>
>>>> Thanks for the explanation.
>>>>
>>>> I did "git gitlab-push" yesterday when I first encountered this problem.
>>>> And today I rebased the commit and did "git gitlab-push --force".  The
>>>> magic still didn't happen. Much unhappiness.
>>>>
>>>> But when I did everything over from scratch, it worked (as mentioned
>>>> in my first email, this was someone else's MR, so I'm not sure what
>>>> the order of operations was the first time around).
>>>>
>>>>  - David
>>>>
>>>> On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen <cory.quammen at kitware.com>
>>>> wrote:
>>>>>
>>>>> As Mathieu said,
>>>>>
>>>>> git gitlab-push
>>>>>
>>>>> does the magic. If you rebase and need to force push on a topic, you
>>>>> can do
>>>>>
>>>>> git gitlab-push -f
>>>>>
>>>>> Cory
>>>>>
>>>>> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal
>>>>> <mathieu.westphal at kitware.com> wrote:
>>>>> > Usually, what i need to do is :
>>>>> >
>>>>> > 1. Copy image into baseline directory
>>>>> > 2. run cmake, check for "staged" output
>>>>> > 3. run make, check for "download" output
>>>>> > 4. git add the md5 file, which has now taken place of your file in
>>>>> > baseline
>>>>> > dir
>>>>> > 5. Commit all you need to commit
>>>>> > 6. git gitlab-push ( magic happens here )
>>>>> >
>>>>> > Mathieu Westphal
>>>>> >
>>>>> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi <david.gobbi at gmail.com>
>>>>> > wrote:
>>>>> >>
>>>>> >> Hi All,
>>>>> >>
>>>>> >> I've got a problem with ExternalData that is driving me crazy.
>>>>> >> CMake
>>>>> >> computed the md5 sum and "staged" the image, whatever that means:
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5
>>>>> >>
>>>>> >> How does it go from here to the midas database? Because that step
>>>>> >> just
>>>>> >> doesn't seem to be happening. This is specifically with respect to
>>>>> >> the
>>>>> >> following merge request:
>>>>> >>
>>>>> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336
>>>>> >>
>>>>> >> Cheers,
>>>>> >>  - David
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> _______________________________________________
>>>>> >> Powered by www.kitware.com
>>>>> >>
>>>>> >> Visit other Kitware open-source projects at
>>>>> >> http://www.kitware.com/opensource/opensource.html
>>>>> >>
>>>>> >> Search the list archives at:
>>>>> >> http://markmail.org/search/?q=vtk-developers
>>>>> >>
>>>>> >> Follow this link to subscribe/unsubscribe:
>>>>> >> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>>> >>
>>>>> >>
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > Powered by www.kitware.com
>>>>> >
>>>>> > Visit other Kitware open-source projects at
>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>> >
>>>>> > Search the list archives at:
>>>>> > http://markmail.org/search/?q=vtk-developers
>>>>> >
>>>>> > Follow this link to subscribe/unsubscribe:
>>>>> > http://public.kitware.com/mailman/listinfo/vtk-developers
>>>>> >
>>>>> >
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Cory Quammen
>>>>> R&D Engineer
>>>>> Kitware, Inc.
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Search the list archives at:
>>>> http://markmail.org/search/?q=vtk-developers
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> William J. Schroeder, PhD
>>> Kitware, Inc. - Building the World's Technical Computing Software
>>> 28 Corporate Drive
>>> Clifton Park, NY 12065
>>> will.schroeder at kitware.com
>>> http://www.kitware.com
>>> (518) 881-4902
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>
>>>
>>
>>
>>
>> --
>> Ken Martin PhD
>> Chairman & CFO
>> Kitware Inc.
>> 28 Corporate Drive
>> Clifton Park NY 12065
>> 518 371 3971
>>
>> This communication, including all attachments, contains confidential and
>> legally privileged information, and it is intended only for the use of the
>> addressee.  Access to this email by anyone else is unauthorized. If you are
>> not the intended recipient, any disclosure, copying, distribution or any
>> action taken in reliance on it is prohibited and may be unlawful. If you
>> received this communication in error please notify us immediately and
>> destroy the original message.  Thank you.
>
>
>
>
> --
> William J. Schroeder, PhD
> Kitware, Inc. - Building the World's Technical Computing Software
> 28 Corporate Drive
> Clifton Park, NY 12065
> will.schroeder at kitware.com
> http://www.kitware.com
> (518) 881-4902
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>



-- 
Unpaid intern in BillsBasement at noware dot com


More information about the vtk-developers mailing list