[vtk-developers] PROPOSAL: Changing VTK's indentation style

Brad King brad.king at kitware.com
Wed Sep 9 10:56:41 EDT 2015


On 09/09/2015 10:46 AM, Ben Boeckel wrote:
> On Wed, Sep 09, 2015 at 08:12:21 -0600, David Gobbi wrote:
>> The only styling change that the robot should do is removal of the two
>> preceding spaces before the braces.  Otherwise, we will have to contend
>> with the law of unintended consequences.
> 
> Agreed. It will also (hopefully) keep "blame poisoning" down to just
> brace-only lines.

No.  If we are going to change style any more than just {} indentation
then blame poisoning is inevitable.  The only way to avoid it would be
to make style changes incrementally as code is edited, but that would
be very confusing.  Given that such style updates must be done as a
sweeping commit, would we rather blame kwrobot or a person?

In CMake's own source we made a few sweeping kwrobot commits to
update whitespace and convert *.cmake commands to lower case.  Those
few commits still regularly show up in blame output but it is not
very bothersome to blame starting from $blamed~1 instead.

-Brad



More information about the vtk-developers mailing list