[vtk-developers] int to bool patch, white space convention?

[Sean McBride]

On Tue, 17 Nov 2015 08:56:56 -0500, Cory Quammen said:

>I commented on the gitlab issue, but I'll reiterate here. I'm worried about
>backwards incompatibilities this might introduce. In most cases, you should
>be fine. But I have suspicions things may be more complicated than they
>first appear.

Yes, it's a slight backwards compatibility break.  The last commit (of 4) shows the kind of compile issues that could result.  The biggest example is probably if you override the changed methods, you'd need your overrides to match signature.

It's a tradeoff.  We gain clearer code, better self-documentation, possibility of better compiler warnings (like SetBoolThing(123) could now warn).

>We'll need to test ParaView build with this change at the very least...

Thanks!

Sean