[vtk-developers] How to update someone else's topic (or create a new topic off of theirs)

Shawn Waldon shawn.waldon at kitware.com
Tue Mar 17 14:56:54 EDT 2015

On Tue, Mar 17, 2015 at 2:48 PM, Ken Martin <ken.martin at kitware.com> wrote:

> I apologize if these are stupid questions but I'm exploring this a tad
> further as it hits on the basic way we will collaborate on a topic and I
> want to make sure I do it the right way.
> So basically
> 1) Checkout their topic from their fork of VTK (the topic does not exist
> yet
> on other forks right?)

Correct, the topic branch only exists on their fork.

> 2) Do some work
> Then...
> I can push it to their fork if they add me as a developer on their fork.


> Can I push it to my fork even though my fork lacks their topic?  Should I?
> Yes, it will create a branch on your fork with that name.  The merge
request will not be updated though.

> They cannot fetch it from me unless I push it someplace public that they
> can
> see right? Where would that be? Github?
> In the Settings section of your fork you can make your fork public.  Forks
of public projects on Gitlab are public by default so unless you changed it
your fork of VTK should be publicly visible.  Then if they fetch that
branch from your fork they will get your changes.


> Thanks!
> Ken
> Ken Martin PhD
> Chairman & CFO
> Kitware Inc.
> 28 Corporate Drive
> Clifton Park NY 12065
> ken.martin at kitware.com
> 518 881-4901 (w)
> 518 371-4573 (f)
> This communication, including all attachments, contains confidential and
> legally privileged information, and it is intended only for the use of the
> addressee.  Access to this email by anyone else is unauthorized. If you are
> not the intended recipient, any disclosure, copying, distribution or any
> action taken in reliance on it is prohibited and may be unlawful. If you
> received this communication in error please notify us immediately and
> destroy the original message.  Thank you.
> -----Original Message-----
> From: Brad King [mailto:brad.king at kitware.com]
> Sent: Tuesday, March 17, 2015 2:24 PM
> To: Ken Martin
> Cc: VTK Developers
> Subject: Re: How to update someone else's topic (or create a new topic off
> of theirs)
> On 03/17/2015 02:16 PM, Ken Martin wrote:
> > So I was doing a review of someone's merge request and I realized it
> > needs some extra changes. Is there a way for me to download their
> > topic (cherry pick?), make some more changes and then resubmit it? I
> > saw lots of options to download a patch or diff for a topic but I do
> > not want to lose their node/hash/whatever it is called. Is there a
> > right way to do this. I did check the wiki but did not see a "revise
> > someone else's topic".
> This is an area where GitLab's merge request workflow differs from
> Gerrit's.
> In GitLab the original submitter of the merge request is responsible for
> pushing all updates to the branch.  There are a few options here:
> 1. You could checkout the branch locally, make the changes, and then ask
>    the original submitter to fetch your version of the topic and
>    'git gitlab-push' it again to update the MR.
> 2. You could do the same but instead open your own MR and close the
>    original.
> 3. You could work with the submitter directly in their repository.  They
>    can use the Setting tab in their GitLab fork to make you a developer
>    that can push directly to their repository.  In that case though
>    the 'git gitlab-push' alias won't help you because it won't be
>    configured to push to the right place.  You'd have to push by hand.
> -Brad
> _______________________________________________
> Powered by www.kitware.com
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150317/03925b82/attachment.html>

More information about the vtk-developers mailing list