[vtk-developers] Nomenclature - "Reference" data set

[David Gobbi]

So the VTK method names (in VTK 6 style) would be these:

SetReferenceImageConnection()
SetReferenceImageData()
GetReferenceImage()

But, yes, I'm tempted to use SetInputImage() and not use the Data suffix.

 - David


On Tue, Jun 30, 2015 at 3:29 PM, Bill Lorensen <bill.lorensen at gmail.com>
wrote:

> Since vtkImageChangeInformation deals with images, I think
> SetReferenceImage is a logical choice.
>
>
> On Tue, Jun 30, 2015 at 5:26 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> > In ITK we use ReferenceImage in the itkChangeInformationImageFilter.
> >
> > On Tue, Jun 30, 2015 at 5:09 PM, David Gobbi <david.gobbi at gmail.com>
> wrote:
> >> Hi All,
> >>
> >> I have three filters in VTK that have a method called
> >> "SetInformationInput()", but the method name is confusing and I'm
> seeking
> >> advice on how to change it.
> >>
> >> The method's purpose it to provide a reference image.  For example,
> >> vtkImageChangeInformation has two inputs: the first image provides the
> voxel
> >> data, and the 2nd input provides a reference image that has the desired
> >> voxel spacing and origin.  Another example is vtkImageReslice, which can
> >> resample its first input by using the spacing &  origin of a second
> input.
> >>
> >> I looked to see if any geometry filters to see if any of them had a good
> >> name for such an input, and I found that vtkProbeFilter and vtkGlyph3D
> use
> >> the name "SetSourceConnection()".  That name doesn't sound right for the
> >> image filters.
> >>
> >> So, I'm thinking of renaming
> >> vtkImageChangeInformation::SetInformationInputData() as follows, to
> make its
> >> meaning more apparent:
> >>
> >>    SetReferenceData() - accepts a vtkDataObject
> >>    SetReferenceConnection() - creates a pipeline connection
> >>
> >> Imaging scientists generally understand what is meant by a "reference"
> image
> >> in this context.  The old method (which only accepts data, not a
> pipeline
> >> connection) would be deprecated in VTK 7.
> >>
> >> Any thoughts?
> >>
> >>  - David
> >>
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Search the list archives at:
> http://markmail.org/search/?q=vtk-developers
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://public.kitware.com/mailman/listinfo/vtk-developers
> >>
> >>
> >
> >
> >
> > --
> > Unpaid intern in BillsBasement at noware dot com
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150630/35dc88c5/attachment-0001.html>