[vtk-developers] Possible fix for vtkImageStencilData::InsertAndMergeExtent
Xabi Riobe
xabivtk at gmail.com
Thu Jul 30 03:05:58 EDT 2015
Hi,
I'm in the process of migrating from 5.10.1 to 6.3 and have found a fix i
had in vtkImageStencilData::InsertAndMergeExtent from one year ago.
at the end of the method there is this loop:
while (r1 < clist[insertIndex-1])
{
clist[insertIndex] = clist[insertIndex-2];
clist[insertIndex+1] = clist[insertIndex-1];
insertIndex -= 2;
}
and i have this line added : if (insertIndex <= 1) break;
with the comment: "avoid accessing out of range elements, which produces
incorrect stencil that causes a random crash later when used in
vtkImageStencilExecute"
This random crash occured on Mac, never reproduced on Windows.
I was wondering if by looking at the code you think it's a correct fix that
can be merged.
Thanks
Xabi.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150730/7a730861/attachment.html>
More information about the vtk-developers
mailing list