[vtk-developers] Adding a GIL ensure call before all call to python

[Mathieu Westphal]

Ok, so we may add another option in cmake like :
VTK_PYTHON_GIL_EVERYWHERE, so it will not break anything.




Mathieu Westphal

On Fri, Jul 3, 2015 at 3:59 PM, David E DeMarle <dave.demarle at kitware.com>
wrote:

> This was the commit I was referring to.
> http://review.source.kitware.com/#/c/11214/
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
> On Fri, Jul 3, 2015 at 8:47 AM, David E DeMarle <dave.demarle at kitware.com>
> wrote:
>
>> Careful there. We took something very much like that out at ParaView 4.0.
>> The GIL made ParaView incompatible with many python packages. When I get to
>> my desk I can check my notes and refresh my memory.
>> On Jul 3, 2015 5:56 AM, "Mathieu Westphal" <mathieu.westphal at kitware.com>
>> wrote:
>>
>>> A client requesting us to apply a patch to paraview so every single call
>>> to python
>>> (PyRun, Py_Decref, PyImport, PyObject, PyString... ) to be surrounded by
>>> PyGILState_Ensure
>>> PyGILState_Release
>>>
>>> if VTK_NO_PYTHON_THREADS is not defined.
>>>
>>> is this acceptable ? some python calls are already done like that, see
>>> vtkPythonUtil.cxx.
>>>
>>> This option is defined to 1 by default.
>>>
>>>
>>> Mathieu Westphal
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Search the list archives at:
>>> http://markmail.org/search/?q=vtk-developers
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150707/77a7ac42/attachment.html>