[vtk-developers] Dashboard warning vtkStructuredData.h

[David Lonie]

Thanks for the heads up -- I'm working on a cleanup branch for this topic
now, and will add these fixes to it.

Dave

On Tue, Jan 6, 2015 at 1:39 PM, David Gobbi <david.gobbi at gmail.com> wrote:

> The mingw dashboard is showing tons of warnings about the inline
> methods in vtkStructuredData.h
>
> https://open.cdash.org/viewBuildError.php?type=1&buildid=3641101
>
> I believe that this is due to the order in which the inlined methods
> are defined.  Specifically, inline methods should not be used prior to
> their definition, otherwise the mingw compiler complains.
>
> For example, this:
>
>   inline vtkIdType vtkStructuredData::GetNumberOfCells(int ext[6], int)
>   {
>     int cellDims[3];
>     vtkStructuredData::GetCellDimensionsFromExtent(ext,cellDims);
>     ...
>   }
>
> appears in the header file before this:
>
>   inline void vtkStructuredData::GetCellDimensionsFromExtent(
>       int ext[6], int celldims[3], int)
>   {
>     celldims[0] = vtkStructuredData::Max(ext[1] - ext[0], 0);
>     celldims[1] = vtkStructuredData::Max(ext[3] - ext[2], 0);
>     celldims[2] = vtkStructuredData::Max(ext[5] - ext[4], 0);
>   }
>
> If the definition of GetCellDimensionsFromExtent() appeared before the
> definition of GetNumberOfCells(), then mingw wouldn't complain.
>
>   - David
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150106/90962982/attachment.html>