[vtk-developers] Request for a gentler tone in commit message verbiage...

David Lonie david.lonie at kitware.com
Thu Apr 30 10:33:09 EDT 2015


Also, as Robert pointed out earlier, there is an obscure, known issue
concerning NULL conversion and pair constructors in MSVC 2010 that
contributed to this debacle. It is my understanding that NULL (even defined
as (int)0) should convert cleanly to a pointer type, so long as the pointer
type is deducible from template arguments or other contextual information.

In any case, the code is happily functioning on all of our support
platforms now, and I've spent far, far too much time writing, rewriting,
rewriting again, documenting, and redocumenting this single line of code
for my taste. Hopefully the pending merge request will quell any
outstanding concerns.

Dave

On Thu, Apr 30, 2015 at 10:20 AM, Robert Maynard <robert.maynard at kitware.com
> wrote:

> Actually the definition of NULL is left up to each compiler. The C++11
> draft states "The macro NULL < snip> is an implementation-defined C++
> null pointer constant"
>
> On Thu, Apr 30, 2015 at 10:17 AM, Brad King <brad.king at kitware.com> wrote:
> > On 04/30/2015 10:08 AM, David Cole via vtk-developers wrote:
> >> That in some implementations NULL is defined simply as 0. Stupidly,
> >> but still a fact.
> >>
> >> Even in VS 2013, with __cplusplus defined, NULL is simply #define'd to
> 0.
> >
> > IIRC the C++ standard *requires* that NULL be just "0".
> > Its conversion problems are why C++11 introduced nullptr.
> >
> > -Brad
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> >
> > Search the list archives at:
> http://markmail.org/search/?q=vtk-developers
> >
> > Follow this link to subscribe/unsubscribe:
> > http://public.kitware.com/mailman/listinfo/vtk-developers
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150430/f43b0f1b/attachment.html>


More information about the vtk-developers mailing list