[vtk-developers] Request for a gentler tone in commit message verbiage...

[David Lonie]

On Wed, Apr 29, 2015 at 3:54 PM, David Lonie <david.lonie at kitware.com>
wrote:

> On Wed, Apr 29, 2015 at 3:44 PM, Sean McBride <sean at rogue-research.com>
> wrote:
>
>> On Wed, 29 Apr 2015 13:50:53 -0400, David Cole via vtk-developers said:
>>
>> >claims there was some sort of problem with make_pair and double. What
>> >exactly was the problem? With what exact version of MSVC? (I don't buy
>> >that there's a general problem with make_pair and double...)
>>
>> I'll steer clear of the larger point... :)  but will just say: when
>> adding workarounds for problematic compilers / OSes, it would be very
>> appreciated to be clear about which versions.  As someone who has gone
>> through VTK to expunge obsolete workarounds, it's sometimes been hard to
>> know what's obsolete and what's not.  A lot of workaround notes say things
>> like "on Apple this is broken", but which OS version is not stated...
>>
>> Try to think of the future in commit messages and code comments.  :)
>
>
> +1. In this case, the workaround is still valid code, no alternate paths,
> and just a slight change in syntax, so we won't have to worry about
> removing it in the future :D I did leave a note in-line warning future
> maintainers that the line is troublesome for MSVC and should be treated
> with caution.
>
> I am somewhat curious what version of the compiler this was too, I can't
> really tell from the CDash page:
>
> https://open.cdash.org/viewBuildError.php?buildid=3784595
>

It was MSVC 13, for anyone who's curious.

Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150429/ce9b9ddf/attachment.html>