[vtk-developers] Request for a gentler tone in commit message verbiage...

Sean McBride sean at rogue-research.com
Wed Apr 29 15:44:07 EDT 2015


On Wed, 29 Apr 2015 13:50:53 -0400, David Cole via vtk-developers said:

>claims there was some sort of problem with make_pair and double. What
>exactly was the problem? With what exact version of MSVC? (I don't buy
>that there's a general problem with make_pair and double...)

I'll steer clear of the larger point... :)  but will just say: when adding workarounds for problematic compilers / OSes, it would be very appreciated to be clear about which versions.  As someone who has gone through VTK to expunge obsolete workarounds, it's sometimes been hard to know what's obsolete and what's not.  A lot of workaround notes say things like "on Apple this is broken", but which OS version is not stated...

Try to think of the future in commit messages and code comments.  :)

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada




More information about the vtk-developers mailing list