[vtk-developers] Approving a gitlab topic

[David E DeMarle]

"+1 and +2" are familiar to all of us since we learned them all (after a
while) from gerrit. We should continue to strive to make it easy on newbies
too.

+1 for buttons

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909

On Wed, Apr 15, 2015 at 4:20 PM, Bill Lorensen <bill.lorensen at gmail.com>
wrote:

> Buttons are great. No need to remember the quirks of the process.
>
>
> On Wed, Apr 15, 2015 at 4:15 PM, Sean McBride <sean at rogue-research.com>
> wrote:
> > Even that is hard to remember (though better).  Would it not be possible
> to put buttons with names like "Approved" and "Approved & Tested".  Then
> one has nothing to remember.
> >
> > Sean
> >
> >
> >
> > On Wed, 15 Apr 2015 15:48:43 -0400, Robert Maynard said:
> >
> >>Hi Bill,
> >>
> >>I was discussing this with other developers a few days ago and
> >>mentioned that the Acked-by/etc are hard to remember and proposed that
> >>we allow +1 to mean approved by a developer, and +2 to mean approved
> >>and tested.
> >>
> >>On Wed, Apr 15, 2015 at 3:27 PM, Bill Lorensen <bill.lorensen at gmail.com>
> >>wrote:
> >>> To approve a gitlab topic I do?
> >>>
> >>> Acked-by: me
> >>>
> >>> Why not?
> >>>
> >>> Approved-by: me
> >>>
> >>> The latter seems more descriptive.
> >>>
> >>>  I currently contribute to 3 open source projects, vtk(gitlab),
> >>> itk(gerrit) and slicer(github). They each have their own workflow. I
> >>> also have several of my own projects that uses github. I contribute to
> >>> these projects in spurts.
> >
> >
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150415/b01cf07e/attachment-0001.html>