[vtk-developers] Active scalars and the behavior of vtkAppendFilter

David Thompson david.thompson at kitware.com
Fri May 2 15:36:03 EDT 2014


+1. I see no reason to be backwards-compatible with a bug. I cannot see a case where the changes would be incompatible with anything sane the filter did previously; all the corner cases resulted in buggy output.

	David

On May 2, 2014, at 12:57 PM, Berk Geveci <berk.geveci at kitware.com> wrote:

> A flag is additional complication that we need to maintain pretty much forever. I'd say break backwards compatibility and go with names over attributes. We made the switch to favoring array names over attributes long time ago. This somehow fell through cracks so consider it fixing an old bug.
> 
> -berk
> 
> 
> 
> On Fri, May 2, 2014 at 12:18 PM, Cory Quammen <cory.quammen at kitware.com> wrote:
> Consider Backwards Compatibility?
> 
> Yes, there is that to consider. The most backwards compatible-friendly
> ways to make any changes would be to either
> 
> 1) add a flag that determines whether to merge by active attribute
> (current behavior) or merge by name only, defaulting to the first
> option to retain the current behavior, or
> 
> 2) create a separate filter that merges only by name.
> 
> Option 2 seems too bloaty to me. Option 1 keeps the element of
> surprising behavior by default, but maintains backwards compatibility,
> and appropriate documentation of the merging options should hopefully
> make it easy for someone to choose the behavior they might have been
> expecting.
> 
> Option 1 sounds the best to me.
> 
> Cory
> 
> On Fri, May 2, 2014 at 12:08 PM, David Thompson
> <david.thompson at kitware.com> wrote:
> >>  CBC.
> >
> > Complete Blood Count? Canadian Broadcasting Company?
> >
> >         David
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
> 
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
> 
> 




More information about the vtk-developers mailing list