[vtk-developers] vtk-developers Digest, Vol 119, Issue 6

[Andrew Maclean]

Hi All,
"git log --follow" is a good idea.
Personally I have been trying to be a little more proactive in that I am
keeping an eye on all new submissions and reviewing things I know something
about especially when no reviewers have been added.

This touches on a question that I asked a while back:
Does anyone know how to query gerrit looking for submissions that have no
reviewers added?

A good case in point here was:
http://review.source.kitware.com/#/c/14373/where there were no
reviewer(s) added. I only noticed it because I was
monitoring all the gerrit submissions.

Regards
   Andrew


> ---------- Forwarded message ----------
> From: David E DeMarle <dave.demarle at kitware.com>
> To: xabivtk <xabivtk at gmail.com>
> Cc: vtkdev <vtk-developers at vtk.org>
> Date: Tue, 11 Mar 2014 10:09:56 -0400
> Subject: Re: [vtk-developers] reviewers to add?
> I do a "git log --follow" for the classes I intend to modify and ask the
> most recent few developers who have touched the classes in question.
>
> If I know who champions the code in question I ask them first. A very
> dated version of this bit is on:
> http://www.vtk.org/Wiki/VTK/Managing_the_Development_Process
> If anyone wants to update that and put it on a new page please do so.
>
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
>
> On Tue, Mar 11, 2014 at 6:09 AM, xabivtk <xabivtk at gmail.com> wrote:
>
>> Hi,
>>
>> I'm bringing back this question since i'm facing it now.
>> What is the recommendation to select the reviewers for gerrit?
>>
>> The first guess is to find one that has been implied at some time in the
>> classes we want to modify, but what if there are no one, or we want to add
>> new classes?
>>
>> The wiki page for module/reviewers list as in ITK seems a good idea.
>>
>>
>>
>> --
>> View this message in context:
>> http://vtk.1045678.n5.nabble.com/reviewers-to-add-tp4892420p5726247.html
>> Sent from the VTK - Dev mailing list archive at Nabble.com.
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>>
>
> _______________________________________________
> vtk-developers mailing list
> vtk-developers at vtk.org
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>


-- 
___________________________________________
Andrew J. P. Maclean

___________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.vtk.org/pipermail/vtk-developers/attachments/20140312/90062585/attachment.html>