[vtk-developers] GeoJSONReader HeaderTest failed due to Multiple Includes

[David E DeMarle]

On Thu, Jun 26, 2014 at 10:47 AM, Jatin Parekh <jatinparekh93 at gmail.com>
wrote:

> VTKIOGEOJSON_EXPORT


Means that you need to put this macro (defined by vtk's cmake scripts) in
your class definitions. It makes declspecs for windows shared lib builds.
As Aashish says, see other vtk headers for examples. You will see how they
all include a configured header that defines it.

has 2 includes


The multiple headers is a vtk style guideline. To keep compilation quick
and declarations contained the guidelines recommend a single include per
header file. In practice we need two since modularization for the modern
export macros but that is beside the point. If you need more than three
includes in your header then you should rethink the design. If you have two
or three then you can get through this style check by adding a short
comment after each include which describes why you need to include more
than one header.

See:
https://docs.google.com/a/kitware.com/document/d/1nzinw-dR5JQRNi_gb8qwLL5PnkGMK2FETlQGLr10tZw/edit

for a wealth of information about vtk's style guidelines.






David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20140626/5b9dcbf6/attachment-0002.html>