[vtk-developers] zero-copy mixed language support in vtkDataArray

[Ben Boeckel]

On Fri, Jan 17, 2014 at 12:37:56 -0800, Burlen Loring wrote:
> I'm interested to here peoples thoughts on this change. if there are
> no objections to the concept/approach, would anyone be willing to
> review?
> http://review.source.kitware.com/#/c/14072/2

These overrides aren't going to be wrapped, so will only be accessible
from C++ code. Is that the intention? If pure Python or Fortran is to
use these, the wrapping code will need to be extended to handle these
(for each language). To be fair, I only know the Python wrapping to any
real degree though.

It'd actually probably be easier to make a class than to teach the
wrappers to pair up the callback/callbackData parameters…but then you'd
need to teach at least Python about the ability to call virtual methods
from C++ into Python.

Also, please document that callbackData is to be deleted by the callback
itself (and I'd say that the fallback to using the array as the
callbackData shouldn't happen so that the callback doesn't need to
change whether NULL or something else is given as the context). Maybe
just pass the array as the first parameter and callbackData as the
second would work as well.

--Ben