[vtk-developers] Minimum Python requirement

David Gobbi david.gobbi at gmail.com
Thu Feb 13 12:55:10 EST 2014


Actually, the check should probably be done in the CMakeLists.txt:

if(${PYTHON_VERSION} VERSION_GREATER "2.6")
  vtk_add_test_python(TestImageJSONWriter.py NO_VALID)
endif()

On Thu, Feb 13, 2014 at 10:43 AM, David Gobbi <david.gobbi at gmail.com> wrote:
> I agree with this.  It is the tests that should do the version checks.
> The burden should not be placed on the people running the dashboard
> machines.
>
> On Thu, Feb 13, 2014 at 10:34 AM, Ben Boeckel <ben.boeckel at kitware.com> wrote:
>> On Thu, Feb 13, 2014 at 09:51:28 -0700, Sebastien Jourdain wrote:
>>> vtk-web / pv-web even require 2.7 for the web server part.
>>>
>>> I vote to disable that test for that machine.
>>
>> I'd say a patch to just not even enable the tests if Python isn't new
>> enough would be better (rather than per-machine tweaks). The JSONExport
>> test should probably just not validate the output if using Python < 2.6
>> so that we know whether the code at least runs correctly.
>>
>> --Ben
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>



More information about the vtk-developers mailing list