[vtk-developers] Proposal to add "vtkInfoMacro"

[Berk Geveci]

I disagree with this change. There is no compelling VTK specific example
for why this is needed. The examples are all from Slicer - which to me says
that they can be implemented in Slicer.

Adding a logging functionality without clear guidelines on how to use it is
dangerous. It can lead to folks using it for debugging in performance
critical sections and since it is not compiled out in Release builds, it
can lead to significant performance issues, specially in multi-threaded
code. As it is, there are lot of minor issues like this that we will have
to go and clean up (progress being one of them).

The main use case seems to be tracking interaction/workflow changes. My
suggestion is to employ a method appropriate to that. For example, events
and listeners.

Best,
-berk


On Thu, Dec 11, 2014 at 12:06 PM, Jean-Christophe Fillion-Robin <
jchris.fillionr at kitware.com> wrote:
>
> Hi Folks,
>
> While developing 3D Slicer, we created a macro named
>
>                                           vtkInfoMacro
>
> similar to "vtkErrorMacro/vtkDebugMacro/vtkWarningMacro".
>
>
> We would like to contribute it back to VTK core.
>
>
>
> The associated topic is:
>
>                       http://review.source.kitware.com/#/c/18385/
>
>
> It would be great to get feedback before moving forward.
>
> Thanks
> Jc
>
>
> --
> +1 919 869 8849
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20141212/a654fcc2/attachment-0001.html>