[vtk-developers] Possible vtkScalarBarActor improvement

[Jean-Christophe Fillion-Robin]

Thanks for commenting. In that case, we gonna move forward and integrate
Kevin topic into Slicer.

@Kevin: In the commit message and/or doxygen, I would suggest that you
write down how it  could be done using VTK 6. That way the transition to
VTK 6 will be even easier.

@David: Do you see anything in the API proposed by Kevin that could be
changed to be closer to what is possible in VTK 6 ?
See [1]

Jc

[1]
https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6


On Mon, Sep 16, 2013 at 3:38 PM, David Thompson
<david.thompson at kitware.com>wrote:

> Hi all,
>
> > I took a quick look at vtkScalarBarActor/vtkScalarsToColors and saw
> quite a bit changes between 5.10 and 6.0. ...
>
> Yes, it uses the new matplotlib MathText rendering engine to draw labels
> and that required a lot of skullduggery to get working with VTK 6's
> modules. I would advise against trying to backport it.
>
>         David
>
> >
> > From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com]
> > Sent: Monday, September 16, 2013 12:41 PM
> > To: Wang, Kevin
> > Cc: David Thompson; vtk-developers at vtk.org
> > Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
> >
> > Hi Kevin,
> >
> > I would suggest you a submit a pull request to the SlicerVTK fork
> backporting the functionality you would like. Then, when we will transition
> to VTK6, it will go very smoothly.
> >
> > In parallel, you could also submit a patch to the VTK list that would be
> integrated to the VTK 5.10 maintenance branch.
> >
> > Thanks
> > Jc
> >
> >
> > On Mon, Sep 16, 2013 at 11:24 AM, Wang, Kevin <kevin.wang at rmp.uhn.on.ca>
> wrote:
> > Thanks David. I think I am ok with switching the vtkStringArrays on the
> fly.
> >
> > Kevin
> >
> > -----Original Message-----
> > From: David Thompson [mailto:david.thompson at kitware.com]
> > Sent: Monday, September 16, 2013 11:17 AM
> > To: Wang, Kevin
> > Cc: 'Jean-Christophe Fillion-Robin'; vtk-developers at vtk.org
> > Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
> >
> > Hi Kevin,
> >
> > > The SetAnnotation method in vtkScalarsToColors is what I need in deed.
> ...
> >
> > Great.
> >
> > > The interface is fine. I wonder if it is possible to add a method to
> control whether values are used for labels in the vtkScalarBarActor or the
> annotations are used. ...
> >
> > I would be willing to consider adding something to the
> vtkScalarsToColors class to switch between sets of strings if we can come
> up with a clean API that preserves backwards-compatability -- but don't
> think the class should be  responsible for generating a string label for
> each value; it is very hard to get otherwise-rational people to agree on
> how to format numbers and vtkVarints as text. :-)
> >
> >         David
> >
> >
> > This e-mail may contain confidential and/or privileged information for
> the sole use of the intended recipient.
> > Any review or distribution by anyone other than the person for whom it
> was originally intended is strictly prohibited.
> > If you have received this e-mail in error, please contact the sender and
> delete all copies.
> > Opinions, conclusions or other information contained in this e-mail may
> not be that of the organization.
> >
> >
> >
> >
> > --
> > +1 919 869 8849
> >
> > This e-mail may contain confidential and/or privileged information for
> the sole use of the intended recipient.
> > Any review or distribution by anyone other than the person for whom it
> was originally intended is strictly prohibited.
> > If you have received this e-mail in error, please contact the sender and
> delete all copies.
> > Opinions, conclusions or other information contained in this e-mail may
> not be that of the organization.
>
>


-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130917/25bb5830/attachment.html>