[vtk-developers] [cmake-developers] Warnings with CMake 2.8.12-rc3 driving dashboards

Brad King brad.king at kitware.com
Wed Sep 11 12:40:18 EDT 2013


On 09/11/2013 12:32 PM, Brad King wrote:
> I think ninja writes that file out temporarily.  Therefore the
> ninja build files must have the /link option in them somewhere.

Okay, I found the problem.  There was a Ninja-specific change made
here to do linking with response files:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e31df039

That commit added special handling for /link with executables
of which I was not aware when I made this change in 2.8.12:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fb9f73de

The latter change switches from cl.exe to link.exe for linking
executables and of course the latter does not know about /link.

Try this patch:

diff --git a/Modules/Platform/Windows-MSVC.cmake b/Modules/Platform/Windows-MSVC.cmake
index 685638a..8cb7fd5 100644
--- a/Modules/Platform/Windows-MSVC.cmake
+++ b/Modules/Platform/Windows-MSVC.cmake
@@ -231,7 +231,6 @@ macro(__windows_compiler_msvc lang)
   set(CMAKE_${lang}_CREATE_ASSEMBLY_SOURCE
     "<CMAKE_${lang}_COMPILER> ${CMAKE_START_TEMP_FILE} ${CMAKE_CL_NOLOGO}${_COMPILE_${lang}} <FLAGS> <DEFINES> /FoNUL /FAs /Fa<ASSEMBLY_SOURCE> /c <SOURCE>${CMAKE_END_TEMP_FILE}")

-  set(CMAKE_${lang}_COMPILER_LINKER_OPTION_FLAG_EXECUTABLE "/link")
   set(CMAKE_${lang}_USE_RESPONSE_FILE_FOR_OBJECTS 1)
   set(CMAKE_${lang}_LINK_EXECUTABLE

-Brad



More information about the vtk-developers mailing list