[vtk-developers] Did I break master? (isnan)
David Gobbi
david.gobbi at gmail.com
Mon Mar 11 17:52:33 EDT 2013
On Mon, Mar 11, 2013 at 3:25 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> On Mon, Mar 11, 2013 at 3:12 PM, Kyle Lutz <kyle.lutz at kitware.com> wrote:
>> On Mon, Mar 11, 2013 at 4:35 PM, Sean McBride <sean at rogue-research.com> wrote:
>>> Hi all,
>>>
>>> Anyone try building master in the last few hours?
>>>
>>> Do you see any errors about isnan()?, like:
>>>
>>> Common/Core/vtkMath.h:1225:11: error: use of undeclared identifier 'isnan'
>>
>> It's working fine for me (Ubuntu 12.10, GCC 4.7). Pulled about half an hour ago.
>
> Works for me too. Clean build ubuntu/gcc-4.2. In fact it works
> better than before, previously it didn't find isnan on my system
> but now it does.
However... Common/Core/vtkMathConfigure.h.in has this:
#include <cmath>
#include <float.h>
So on some platforms we get std::isnan() from cmath, on others we get
::isnan() from float.h. Ugly situation. A safe but ugly solution is
the following:
Common/Core/vtkMathConfigure.h.in:
#include <cmath>
#include <math.h>
#include <float.h>
That covers all the bases.
- David
More information about the vtk-developers
mailing list