[vtk-developers] FW: VTK stacked plot legends patch

[Marcus D. Hanwell]

Hi,

Please see the patch up for review, I was also using this topic to
test a new CDash at Home volunteer.

http://review.source.kitware.com/#/t/2298/

I modified the logic slightly, and added a legend to one of our
regression tests. You can see a failing test

http://open.cdash.org/index.php?&project=VTK&filtercount=2&field1=buildname/string&compare1=63&value1=T2298charts-stacked-plot-legend&field2=buildstarttime/date&compare2=83&value2=2013-3-5%3C/p%3E

(linked from the topic page comments) that shows the new baseline
image. If the change looks good I can get it merged once I get someone
to review it. If there are more improvements you would like to see
please feel free to sign up for a Gerrit account and add me as a
reviewer there.

Thanks,

Marcus

On Mon, Mar 4, 2013 at 5:15 PM, Aaron Knoll <knolla at tacc.utexas.edu> wrote:
> Thanks Marcus!
>
> On 3/4/13 4:15 PM, "Marcus D. Hanwell" <marcus.hanwell at kitware.com> wrote:
>
>>I should be able to take a look at this, it looks like this is against
>>master. Minor comments that vtkNew could be used, I will put something
>>up on Gerrit but I don't see any problem in getting this merged.
>>
>>Marcus
>>
>>On Mon, Mar 4, 2013 at 12:15 PM, Aaron Knoll <knolla at tacc.utexas.edu>
>>wrote:
>>> Hi all, Greg Johnson and I are working on a project using vtkChart's. He
>>> noticed an issue with stacked plots involving legend color; and wrote
>>>this
>>> bit of code to render separate colors as per the legend, as opposed to a
>>> single color. Would it be possible to incorporate this into the VTK
>>> master? Thanks!
>>> -Aaron
>>>
>>> On 3/4/13 11:09 AM, "Gregory P. Johnson" <gregj at tacc.utexas.edu> wrote:
>>>
>>>>
>>>>This patch fixes the colors for legends on VTK stacked plots. Before,
>>>>the
>>>>same color was used for each legend entry, rather than the colors for
>>>>each series. This is based on a current git pull of the VTK repo.
>>>>
>>>>Can you see if you can get the VTK folks to incorporate this patch?
>>>>
>>>>Thanks,
>>>>Greg
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>>http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>>
>