[vtk-developers] Problem with VTK_HAS_STD_ISFINITE

[Andrew Maclean]

I am not sure what happened, but now I am getting clean builds on both the
Mac and Ubuntu. I deleted the folders (which I had previously done) and ran
CMake again and then resultant builds were Ok.
Before doing this I checked for CHECK_CXX_EXPRESSION_COMPILES in
CMakeFiles/CMakeError.log.
There was no entry even though the build was failing at that stage. So I am
not sure what was going on.

I am using CMake 2.8.11.2 on all machines.

Regards
   Andrew



On Wed, Jul 31, 2013 at 11:15 PM, Brad King <brad.king at kitware.com> wrote:

> On 07/31/2013 09:07 AM, Marcus D. Hanwell wrote:
> > On Wed, Jul 31, 2013 at 8:13 AM, David Gobbi <david.gobbi at gmail.com>
> wrote:
> >> The related variable VTK_HAS_ISFINITE is being incorrectly set, but I
> >> can fix that as soon as VTK moves to a more recent version of CMake.
> >> Right now, VTK uses the following check:
> >>  check_symbol_exists(isfinite "math.h" VTK_HAS_ISFINITE)
> >> This check is not valid, because vtkMath includes "cmath", not
> >> "math.h".  The check should really be this:
> >>  check_cxx_symbol_exists(isfinite "cmath" VTK_HAS_ISFINITE)
> >> Unfortunately the cmake_cxx_symbol_exists() macro is not available in
> >> CMake 2.8.5.
> >
> > Will CMake 2.8.8 bring in the feature you need? I proposed bumping our
> > CMake dependency yesterday, it would be good to know if it helps here
> > (or what version is required otherwise).
>
> The check_cxx_symbol_exists macro was added in CMake 2.8.6.
>
> FWIW, Debian stable has CMake 2.8.9 so IMO 2.8.8 is fine
> as a minimum required version.
>
> -Brad
>



-- 
___________________________________________
Andrew J. P. Maclean

___________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130801/7211e979/attachment.html>