[vtk-developers] TestSplitViewportStereoHorizontal

[Aashish Chaudhary]

Ok, I found the issue..it was the vtkTesting, Basically there it
creates a new camera and line by line copies the member variables (I
don't know why we just deep copy the cameras).

There it was missing copying off screen parameters. I will push a fix
tomorrow (need to leave very soon). Along with that I will push fixes
to shallow copy as well.

Thanks


On Wed, Feb 20, 2013 at 4:45 PM, Aashish Chaudhary
<aashish.chaudhary at kitware.com> wrote:
> Thanks David. PartialCopy has issues but it seems like that's not the
> problem. Basically all of the camera parameters are same before and
> after.
>
> Thanks,
>
>
> On Wed, Feb 20, 2013 at 4:12 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>> Look at PartialCopy(), make sure it isn't missing anything.
>>
>>  - David
>>
>>
>> On Wed, Feb 20, 2013 at 2:02 PM, Aashish Chaudhary
>> <aashish.chaudhary at kitware.com> wrote:
>>> Ok, I found something interesting, these settings are gone inside the
>>> call to vtkRegressionTestImageThreshold
>>>
>>> camera->SetScreenBottomLeft(bottomLeft);
>>> camera->SetScreenBottomRight(bottomRight);
>>> camera->SetScreenTopRight(topRight);
>>>
>>> And that's causing it create different images. I don't know the exact
>>> reason yet but this is a progress.
>>>
>>> Thanks,
>>>
>>>
>>> On Wed, Feb 20, 2013 at 3:49 PM, Aashish Chaudhary
>>> <aashish.chaudhary at kitware.com> wrote:
>>>> On Wed, Feb 20, 2013 at 3:36 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>>> Thanks for looking at this, but unfortunately, the mac and pc images
>>>>> do not look the same.
>>>>
>>>> Yeah.. I realized the same. It seems like windows is capturing the
>>>> scene after first render and mac / linux captured that it should be
>>>> after second render. I guess
>>>> I can try to setup camera parameters before hand and see if that
>>>> prevents this behavior.
>>>>
>>>> Thanks
>>>>
>>>>>
>>>>> On Wed, Feb 20, 2013 at 2:27 PM, Aashish Chaudhary
>>>>> <aashish.chaudhary at kitware.com> wrote:
>>>>>> Bill,
>>>>>>
>>>>>> I pushed a branch and hoping that it will fix the issue atleast on mac
>>>>>> and linux. I may have to check for stereo support but I will for that.
>>>>>>
>>>>>> I will keep an eye on the dashboards, in the mean time please review my branch.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 19, 2013 at 11:24 AM, Aashish Chaudhary
>>>>>> <aashish.chaudhary at kitware.com> wrote:
>>>>>>> Bill,
>>>>>>>
>>>>>>> I will have a look at it today.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Feb 18, 2013 at 11:55 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>>>>>> Aashish,
>>>>>>>>
>>>>>>>> TestSplitViewportStereoHorizontal is the only test failing on the Mac
>>>>>>>> Gerrit build (and all OSX systems). It would be great to have it
>>>>>>>> fixed. David Gobbi fixed some failures of this test in this gerrit
>>>>>>>> patch:  http://review.source.kitware.com/#/c/9747/
>>>>>>>>
>>>>>>>> If you try to fix it, please make sure you update to master before
>>>>>>>> doing any work.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Bill
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> | Aashish Chaudhary
>>>>>>> | R&D Engineer
>>>>>>> | Kitware Inc.
>>>>>>> | www.kitware.com
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> | Aashish Chaudhary
>>>>>> | R&D Engineer
>>>>>> | Kitware Inc.
>>>>>> | www.kitware.com
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Unpaid intern in BillsBasement at noware dot com
>>>>
>>>>
>>>>
>>>> --
>>>> | Aashish Chaudhary
>>>> | R&D Engineer
>>>> | Kitware Inc.
>>>> | www.kitware.com
>>>
>>>
>>>
>>> --
>>> | Aashish Chaudhary
>>> | R&D Engineer
>>> | Kitware Inc.
>>> | www.kitware.com
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>
>
>
> --
> | Aashish Chaudhary
> | R&D Engineer
> | Kitware Inc.
> | www.kitware.com



-- 
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com