[vtk-developers] Only 2 warnings left on my dashboards...
David Cole
dlrdave at aol.com
Mon Feb 11 16:16:01 EST 2013
You're gonna have to dig farther back than that to figure out where the flags come from..... I just added double quotes around the thing in my commit so that it would work properly. I have no idea why those flags are necessary there.
-----Original Message-----
From: Sean McBride <sean at rogue-research.com>
To: vtk-developers <vtk-developers at vtk.org>
Cc: Sebastien Jourdain <sebastien.jourdain at kitware.com>; David Cole <dlrdave at aol.com>
Sent: Mon, Feb 11, 2013 3:40 pm
Subject: Only 2 warnings left on my dashboards...
Hi all,
Only 2 warnings left on my dashboards, but I'm not sure how to fix them:
<http://open.cdash.org/viewBuildError.php?type=1&buildid=2807871>
(1)
ld: warning: -read_only_relocs cannot be used with x86_64
I guess the first question is is -read_only_relocs really needed? Looks like
David Cole added it recently:
bf339e85 Utilities/vtkoggtheora/CMakeLists.txt (Dave Demarle
2009-12-01 08:30:17 -0500 123) # set up linker flags
bf339e85 Utilities/vtkoggtheora/CMakeLists.txt (Dave Demarle
2009-12-01 08:30:17 -0500 124) IF(APPLE)
bf339e85 Utilities/vtkoggtheora/CMakeLists.txt (Dave Demarle
2009-12-01 08:30:17 -0500 125) SET( VTKOGGTHEORA_SHARED_LINKER_FLAGS
c993f3fc ThirdParty/oggtheora/vtkoggtheora/CMakeLists.txt (David Cole
2012-04-11 07:34:52 -0400 126) "-read_only_relocs suppress
-Wl,-exported_symbols_list,\"${VTKOGGTHEOR
bf339e85 Utilities/vtkoggtheora/CMakeLists.txt (Dave Demarle
2009-12-01 08:30:17 -0500 127) )
(2)
/Users/builder/external/VTK/Wrapping/Java/vtkJavaAwt.h:57:7: warning:
'JAWT_GetAWT' is deprecated [-Wdeprecated-declarations]
if (JAWT_GetAWT(env, &awt) == JNI_FALSE)
^
This one we just need to suppress. I see from git history that Sebastien
Jourdain tried:
abaa75c2 CMake/CTestCustom.cmake.in (Sebastien Jourdain 2012-10-08 15:32:22
-0400 286)
abaa75c2 CMake/CTestCustom.cmake.in (Sebastien Jourdain 2012-10-08 15:32:22
-0400 287) # Mac OS X and Java moving to Oracle, Apple is deprecating their
own Java Implem
abaa75c2 CMake/CTestCustom.cmake.in (Sebastien Jourdain 2012-10-08 15:32:22
-0400 288) "warning: 'JAWT_GetAWT' is deprecated"
But his technique is not working for whatever reason. An alternative would be
to wrap the use of that API in:
#if __APPLE__ && (MAC_OS_X_VERSION_MAX_ALLOWED >= 1080)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
// use JAWT_GetAWT
#pragma GCC diagnostic pop
#endif
Thoughts?
Thanks,
--
____________________________________________________________
Sean McBride, B. Eng sean at rogue-research.com
Rogue Research www.rogue-research.com
Mac Software Developer Montréal, Québec, Canada
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130211/17aa2ef2/attachment.html>
More information about the vtk-developers
mailing list