[vtk-developers] vtkOpenFOAMReader is untested

Bill Lorensen bill.lorensen at gmail.com
Mon Dec 30 15:40:30 EST 2013


I am flexible. February is also good for me.


On Mon, Dec 30, 2013 at 3:34 PM, David Cole <dlrdave at aol.com> wrote:
> I can join in by online hangout. (Sorry, but I won't be able to be in
> Clifton Park in January.) ((Ok, not *really* sorry.))
>
>
> David C.
>
>
>
> -----Original Message-----
> From: Berk Geveci <berk.geveci at kitware.com>
> To: Bill Lorensen <bill.lorensen at gmail.com>
> Cc: VTK Developers <vtk-developers at vtk.org>
> Sent: Mon, Dec 30, 2013 3:25 pm
> Subject: Re: [vtk-developers] vtkOpenFOAMReader is untested
>
>
> How about Jan 28?
>
>
> -berk
>
>
>
>
> On Fri, Dec 20, 2013 at 2:21 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>
> That is good for me except the day Jan 27 which is my 46th wedding
> anniversary.
>
>
>
> On Fri, Dec 20, 2013 at 2:12 PM, Berk Geveci <berk.geveci at kitware.com>
> wrote:
>>
>> How about during the week of Jan 20 or Jan 27? Sean can also come.
>
> Anyone
>>
>> other than Bill and Sean interested in joining in Clifton Park?
>>
>> Best,
>> -berk
>>
>>
>> On Tue, Dec 17, 2013 at 10:29 PM, Bill Lorensen
>
> <bill.lorensen at gmail.com>
>>
>> wrote:
>>>
>>>
>>> I'm available after the NA-MIC meeting. After Jan 10.
>>>
>>>
>>> On Tue, Dec 17, 2013 at 9:34 PM, David E DeMarle
>>> <dave.demarle at kitware.com> wrote:
>>> > This would be cool to emulate:
>>> >
>>> >
>
> http://www.itk.org/Wiki/ITK/10th_Anniversary_Activities/Dashboard_Fest_1.0
>>>
>>> > Especially if we refine it a bit to focus on number of new tests
>
> created
>>>
>>> > rather than number of submissions.
>>> >
>>> >
>>> > David E DeMarle
>>> > Kitware, Inc.
>>> > R&D Engineer
>>> > 21 Corporate Drive
>>> > Clifton Park, NY 12065-8662
>>> > Phone: 518-881-4909
>>> >
>>> >
>>> > On Tue, Dec 17, 2013 at 9:06 PM, Berk Geveci
>
> <berk.geveci at kitware.com>
>>>
>>> > wrote:
>>> >>
>>> >> Let's do it (the hackathon)!
>>> >>
>>> >> December is probably out. January?
>>> >>
>>> >>
>>> >> On Thu, Dec 12, 2013 at 3:34 PM, David E DeMarle
>>> >> <dave.demarle at kitware.com> wrote:
>>> >>>
>>> >>> I for one would love another hackathon!
>>> >>>
>>> >>> What can we do to make it trivial to create new tests before
>
> hand?
>>>
>>> >>> Clearly documenting the steps and the many utilities to call in
>
> your
>>>
>>> >>> test is
>>> >>> a good start.
>>> >>>
>>> >>> Then at the hackathon we could take a look at the coverage
>
> reports,
>>>
>>> >>> divy
>>> >>> up the poorly documented regions and boost out coverage to a
>>> >>> satisfactory
>>> >>> level. Then we could do what ITK did a while back and have a
>
> dashboard
>>>
>>> >>> day.
>>> >>>
>>> >>> David E DeMarle
>>> >>> Kitware, Inc.
>>> >>> R&D Engineer
>>> >>> 21 Corporate Drive
>>> >>> Clifton Park, NY 12065-8662
>>> >>> Phone: 518-881-4909
>>> >>>
>>> >>>
>>> >>> On Thu, Dec 12, 2013 at 1:45 PM, Bill Lorensen
>>> >>> <bill.lorensen at gmail.com>
>>> >>> wrote:
>>> >>>>
>>> >>>> Berk,
>>> >>>>
>>> >>>> There are several readers in vtk that are untested. I smell
>>> >>>> hackathon!!!
>>> >>>>
>>> >>>> vtkPOpenFOAMReader
>>> >>>> vtkFLUENTReader
>>> >>>> vtkPWindBladeReader
>>> >>>> vtkWindBladeReader
>>> >>>> vtkMFIXReader
>>> >>>> vtkLSDynaReader
>>> >>>> vtkPChacoReader
>>> >>>> vtkSLACReader
>>> >>>> vtkMPIImageReader
>>> >>>> vtkPExodusIIReader
>>> >>>> vtkAMREnzoParticlesReader
>>> >>>> vtkMPASReader
>>> >>>> vtkSLACParticleReader
>>> >>>> vtkPostgreSQLToTableReader
>>> >>>> vtkMySQLToTableReader
>>> >>>> vtkGraphReader
>>> >>>> vtkDIMACSGraphReader
>>> >>>> vtkAMRFlashParticlesReader
>>> >>>> vtkPNetCDFPOPReader
>>> >>>> vtkNetCDFCAMReader
>>> >>>> vtkChacoGraphReader
>>> >>>> vtkRTXMLPolyDataReader
>>> >>>> vtkXMLHyperOctreeReader
>>> >>>> vtkAMRFlashReader
>>> >>>> vtkSESAMEReader
>>> >>>> vtkFixedWidthTextReader
>>> >>>> vtkVPICReader
>>> >>>> vtkUGFacetReader
>>> >>>> vtkISIReader
>>> >>>> vtkRISReader
>>> >>>> vtkTreeReader
>>> >>>> vtkNetCDFPOPReader
>>> >>>>
>>> >>>> and many more under covered.
>>> >>>>
>>> >>>> On Thu, Dec 12, 2013 at 1:20 PM, Berk Geveci
>>> >>>> <berk.geveci at kitware.com>
>>> >>>> wrote:
>>> >>>> > We should test it in VTK. There are other package and
>
> development
>>>
>>> >>>> > teams out
>>> >>>> > there that use that reader. There may be a file or two in the
>>> >>>> > ParaView
>>> >>>> > data
>>> >>>> > repo.
>>> >>>> >
>>> >>>> > -berk
>>> >>>> >
>>> >>>> >
>>> >>>> > On Thu, Dec 12, 2013 at 1:04 PM, Bill Lorensen
>>> >>>> > <bill.lorensen at gmail.com>
>>> >>>> > wrote:
>>> >>>> >>
>>> >>>> >> Folks,
>>> >>>> >>
>>> >>>> >> I have started looking at the code coverage in VTK. Only 2/3
>
> of
>>>
>>> >>>> >> the
>>> >>>> >> code is covered by our tests. This is very low.
>>> >>>> >>
>>> >>>> >> The nearly 4000 lines of code in vtkOpenFOAMReader are
>
> uncovered.
>>>
>>> >>>> >> Can
>>> >>>> >> someone supply a minimal test (or example) and a small
>
> dataset
>>>
>>> >>>> >> that
>>> >>>> >> will exercise this class.
>>> >>>> >>
>>> >>>> >> I believe this class is used in Paraview. Should it be moved
>
> into
>>>
>>> >>>> >> the
>>> >>>> >> Paraview repo?
>>> >>>> >>
>>> >>>> >> Bill
>>> >>>> >>
>>> >>>> >> --
>>> >>>> >> Unpaid intern in BillsBasement at noware dot com
>>> >>>> >> _______________________________________________
>>> >>>> >> Powered by www.kitware.com
>>> >>>> >>
>>> >>>> >> Visit other Kitware open-source projects at
>>> >>>> >> http://www.kitware.com/opensource/opensource.html
>>> >>>> >>
>>> >>>> >> Follow this link to subscribe/unsubscribe:
>>> >>>> >> http://www.vtk.org/mailman/listinfo/vtk-developers
>>> >>>> >>
>>> >>>> >
>>> >>>>
>>> >>>>
>>> >>>>
>>> >>>> --
>>> >>>> Unpaid intern in BillsBasement at noware dot com
>>> >>>> _______________________________________________
>>> >>>> Powered by www.kitware.com
>>> >>>>
>>> >>>> Visit other Kitware open-source projects at
>>> >>>> http://www.kitware.com/opensource/opensource.html
>>> >>>>
>>> >>>> Follow this link to subscribe/unsubscribe:
>>> >>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>> >>>>
>>> >>>
>>> >>>
>>> >>> _______________________________________________
>>> >>> Powered by www.kitware.com
>>> >>>
>>> >>> Visit other Kitware open-source projects at
>>> >>> http://www.kitware.com/opensource/opensource.html
>>> >>>
>>> >>> Follow this link to subscribe/unsubscribe:
>>> >>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>> >>>
>>> >>>
>>> >>
>>> >
>>>
>>>
>>>
>>> --
>>> Unpaid intern in BillsBasement at noware dot com
>>
>>
>>
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
>
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>



-- 
Unpaid intern in BillsBasement at noware dot com



More information about the vtk-developers mailing list