[vtk-developers] Fwd: New valgrind defect after checkins on July 11

burlen burlen.loring at gmail.com
Fri Aug 9 13:13:48 EDT 2013


Hi All,

My patch to VTKValgrindSuppressions.supp had no affect on the karego 
Ubuntu-Valgrind dashboard. Is that file even in use? What's the right 
way to add a suppression for this dashboard?

Burlen

On 07/28/2013 04:44 AM, Bill Lorensen wrote:
>
>
> ---------- Forwarded message ----------
> From: *Burlen Loring* <burlen.loring at gmail.com 
> <mailto:burlen.loring at gmail.com>>
> Date: Sat, Jul 27, 2013 at 7:02 PM
> Subject: Re: [vtk-developers] New valgrind defect after checkins on 
> July 11
> To: Bill Lorensen <bill.lorensen at gmail.com 
> <mailto:bill.lorensen at gmail.com>>
>
>
> Hi Bill,
>
> Thanks for waiting for me to finish my last patch. I wasn't sure if it 
> would change the path through this test since it disabled some OpenGL 
> features for Mesa 7. It looks like we need a suppression for these 
> errors. I've copied the suppressions from the test output into a new 
> patch, http://review.source.kitware.com/#/c/12115/. I wouldn't want to 
> merge it without trying it first, would you (or anyone who has access 
> to karego) mind verifying that this fixes the issue?
>
> Thank you
> Burlen
>
>
> On 7/19/2013 10:22 AM, Bill Lorensen wrote:
>> Burlen,
>>
>> No problem. I just did not want to have it fall through the cracks.
>>
>> Vacation is a much higher priority for sure.
>>
>> Being retired, I'm always on vacation.
>>
>> Regards,
>>
>> Bill
>>
>>
>> On Fri, Jul 19, 2013 at 1:15 PM, Burlen Loring 
>> <burlen.loring at gmail.com <mailto:burlen.loring at gmail.com>> wrote:
>>
>>     Hi Bill,
>>
>>     That would be mine. I commited a change that enabled OpenGL
>>     features (eg FBO) for Mesa that were previously unconditionally
>>     disabled regardless of if the driver supported it or not.  I've
>>     been cleaning dashboard failures that popped up after my patch
>>     and looking at features that were disabled because of Mesa
>>     specific bugs this week and have a patch that addresses a number
>>     of them, http://review.source.kitware.com/#/c/11985/. It's been
>>     reviewed and I have to make another pass over it to address some
>>     minor issues that reviewers found. I am on vacation today and
>>     will be away until Monday. On Monday I plan to make the changes
>>     to my patch and merge asap (once reviewers are satisfied). This
>>     patch may fix the valgrind issues, but if not I will add an
>>     suppression since the error reported by valgrind is in Mesa not VTK.
>>
>>     Thanks for being patient, my vacation is planned at an
>>     inconvenient time!
>>     Burlen
>>
>>
>>     On 7/19/2013 5:13 AM, Bill Lorensen wrote:
>>>     Folks,
>>>
>>>     There were 86 files changed on July 11:
>>>     http://open.cdash.org/index.php?project=VTK&date=2013-07-12
>>>
>>>     This valgrind defect appeared:
>>>     http://open.cdash.org/viewDynamicAnalysisFile.php?id=2973840
>>>
>>>     Bill
>>>
>>>
>>>
>>>
>>>     _______________________________________________
>>>     Powered bywww.kitware.com  <http://www.kitware.com>
>>>
>>>     Visit other Kitware open-source projects athttp://www.kitware.com/opensource/opensource.html
>>>
>>>     Follow this link to subscribe/unsubscribe:
>>>     http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>
>>
>>
>>
>> -- 
>> Unpaid intern in BillsBasement at noware dot com
>
>
>
>
> -- 
> Unpaid intern in BillsBasement at noware dot com
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130809/3ebc0de1/attachment.html>


More information about the vtk-developers mailing list