[vtk-developers] patch for vtkPyramid::EvaluatePosition

[Kathleen S. Biagas]

Thank you very much for merging!

Kathleen

On Wed, 2013-04-03 at 11:11 -0400, Andy Bauer wrote:
> Hi Kathleen,
> 
> Thanks for the fix -- it's been merged into VTK.
> 
> Andy
> 
> 
> 
> On Tue, Apr 2, 2013 at 2:19 PM, Andy Bauer <andy.bauer at kitware.com>
> wrote:
>         Hi Kathleen,
>         
>         
>         Thanks for the patch. I'll take a look at it.
>         
>         Andy
>         
>         
>         
>         On Tue, Apr 2, 2013 at 2:06 PM, Kathleen S. Biagas
>         <biagas2 at llnl.gov> wrote:
>         
>                 I have a patch for vtkPyramid.cxx which corrects a
>                 problem with the
>                 EvaluatePosition method.  I also have a small test
>                 that demonstrates the
>                 problem: it creates a pyramid with vertices at (1.0,
>                 1.0, 1.0), (-1.0,
>                 1.0, 1.0), (-1.0, -1.0, 1.0), (1.0, -1.0, 1.0),(0.0,
>                 0.0, 0.0), then
>                 calls EvaluatePosition for each of the following
>                 Points printing a
>                 message whether the point is considered inside or
>                 outside the cell:
>                 
>                 (0.0, 0.0, -0.03)
>                 (0.0, 0.0, -0.005)
>                 (1.005, 1.005, 1.0)
>                 (0.0, 0.0, 0.5)
>                 
>                 
>                 I couldn't determine how this small test case would
>                 fit within your
>                 testing framework, or I would push it to gerrit with
>                 the vtkPyramid.cxx
>                 patch.  Shall I commit the patch anyway?
>                 
>                 Kathleen
>                 
>                 
>                 Here's various results of the tests with different vtk
>                 versions:
>                 (all run on rhel-6, using gcc-4.4)
>                 
>                 Results of test when run with VTK-5.8:
>                 
>                 Point 0 0 -0.03 is outside the pyramid.
>                 Point 0 0 -0.005 is outside the pyramid.
>                 Point 1.005 1.005 1 is outside the pyramid.
>                 Point 0 0 0.5 is inside the pyramid.
>                 
>                 Results of test when run with snapshot of master from
>                 this morning
>                 (04-02-12):
>                 
>                 Point 0 0 -0.03 is inside the pyramid.
>                 Point 0 0 -0.005 is inside the pyramid.
>                 Point 1.005 1.005 1 is outside the pyramid.
>                 Point 0 0 0.5 is inside the pyramid.
>                 
>                 Results of test with proposed change to
>                 vtkPyramid.cxx:
>                 
>                 Point 0 0 -0.03 is outside the pyramid.
>                 Point 0 0 -0.005 is outside the pyramid.
>                 Point 1.005 1.005 1 is outside the pyramid.
>                 Point 0 0 0.5 is inside the pyramid.
>                 
>                 
>                 _______________________________________________
>                 Powered by www.kitware.com
>                 
>                 Visit other Kitware open-source projects at
>                 http://www.kitware.com/opensource/opensource.html
>                 
>                 Follow this link to subscribe/unsubscribe:
>                 http://www.vtk.org/mailman/listinfo/vtk-developers
>                 
>                 
>         
>         
> 
>