[vtk-developers] Use of std::cout in tests

[Bill Lorensen]

David,

There is not style checknig in VTK, nor is there an consistent style in
VTK. Years ago we had a style and enforced through a third party package.

ITK enforces style with KWStyle and we have nightly tests that check the
style.

To be honest, style is pretty low in priority versus code coverage and
valgrind.

Bill

On Wed, Sep 19, 2012 at 4:52 PM, David Thompson
<david.thompson at kitware.com>wrote:

> I don't want to be so strict about formatting that we start using
>
>   http://uncrustify.sourceforge.net/
>
> as another pass before commits can be pushed to Gerrit, but it would be
> nice to have a "style file" for uncrustify (or a similar tool) that
> embodies the VTK code style so less code review time is spent on formatting
> and more on the logic, documentation, tests, and organization.
>
>         David
>
> On Sep 19, 2012, at 4:40 PM, "Marcus D. Hanwell" <
> marcus.hanwell at kitware.com> wrote:
>
> > On Wed, Sep 19, 2012 at 4:06 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> >> Folks,
> >>
> >> There has been some recent turmoil regarding the use of std::cout in
> tests
> >> versus cout. The current style guidelines recommend the latter.
> >> First, why is this even an issue. Second, can we amend the style to
> allow
> >> std::cout? Much c++ code I see uses std::cout.
> >>
> >> I'd much rather spend time improving VTK'sl ow coverage that argue over
> what
> >> seems to be a non-issue.
> >>
> > I guess I was the source of the aforementioned turmoil. I think it is
> > important to stick to a common style, and actively changing test code
> > to not match the style seems bad to me. I don't see the point in fully
> > specifying std::cout when we have brought it into the global
> > namespace, but if there is a strong feeling we should then my point
> > was simply that we should specify that is the preferred style from
> > this point forward (or that either is acceptable).
> >
> > If we all start modifying the VTK coding standards then our code will
> > be far less consistent, and harder to understand due to using several
> > styles. If there is general agreement on relaxing some parts of the
> > style I really don't feel very strongly, but I think it should be done
> > deliberately rather than on an ad-hoc basis.
> >
> > Where would you draw the line if this should be relaxed? Could
> > standard indentation be used instead of the special VTK indentation in
> > classes I author? I am sure we don't want to allow that, but it does
> > require some definition on what is strictly required and what is
> > advised/optional.
> >
> > Marcus
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
>
>


-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20120919/c91240cf/attachment.html>