[vtk-developers] Move JAVA_OBJECT_MANAGER to vtkObjectBase

[David Gobbi]

Because vtkObject is a subclass of vtkObjectBase, I though that
vtkObject.JAVA_OBJECT_MANAGER would still work.  Or am I
missing something?  I'm not a Java programmer.

Thanks for taking a look.

 - David


On Wed, Oct 24, 2012 at 12:39 PM, Sebastien Jourdain
<sebastien.jourdain at kitware.com> wrote:
> Hi David,
>
> I've looked at it, and it seems fine, although existing Java code that
> are accessing JAVA_OBJECT_MANAGER from vtkObject will fail to compile.
> But it is a trivial fix on there end and I am not sure many Java
> program make a direct access to it... ;-)
>
> I'm ok for the Java side of that patch. ;-)
>
> Seb
>
> On Wed, Oct 24, 2012 at 2:24 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>> Hi Sebastien,
>>
>> I think that you are more familiar with the java wrappers than I am,
>> so could you take a look at a patch for me?  I have moved the
>> JAVA_OBJECT_MANAGER member from vtkObject to vtkObjectBase.
>> I don't think this should cause any problems, but I wanted to check with
>> you just in case.  See the changes to vtkParseJava.c in the following
>> patch set:
>>
>> http://review.source.kitware.com/#/c/8098/
>>
>> The Java tests are still passing after this patch.
>>
>>  - David