[vtk-developers] Reviewing a patch with many changes

Philippe Pebay philippe.pebay at kitware.com
Wed Oct 10 17:37:10 EDT 2012


Hello Bill,

Thanks for your interest. I still have to write some regression tests for
that work. Once it will be done I will squash some of the commits and have
you as the reviewer. Thank you!
Philippe

On Wed, Oct 10, 2012 at 9:03 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Philippe,
>
> Sorry to bring this up again. I would love to review your patch:
> http://review.source.kitware.com/#/t/1441/
>
> But 15 changes for what on the surface seems to be a small change is just
> too much for me to handle. Is there any way you can squash some of these
> commits? For example, I wanted to see how you tested the capabilities but I
> don't want to read 15 changes to find a test.
>
> Bill
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
>


-- 
Philippe Pébay, PhD
Director of Visualization and High Performance Computing /
Directeur de la Visualisation et du Calcul Haute Performance
Kitware SAS
26 rue Louis Guérin, 69100 Villeurbanne, France
+33 (0) 6.83.61.55.70 / 4.37.45.04.15
http://www.kitware.fr <http://www.kitware.fr/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20121010/e47cc84e/attachment.html>


More information about the vtk-developers mailing list