[vtk-developers] accepting 5.10.1 patches

Wed Oct 3 09:02:37 EDT 2012

Last call for 5.10.1 patches.

The patches that have already made it into the release branch are attached.
I plan to tag 5.10.1 and update the download website with new tarballs
early next week.

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909

On Thu, Aug 30, 2012 at 1:01 PM, David E DeMarle
<dave.demarle at kitware.com> wrote:
> On Thu, Aug 30, 2012 at 11:53 AM, Sean McBride <sean at rogue-research.com> wrote:
>> On Thu, 30 Aug 2012 10:28:21 -0400, David E DeMarle said:
>>
>>>We are going to do a 5.10.1 patch release
>>
>> When?
>>
>
> Middle or end of next month. That should give enough time to identify,
> patch and test any show stoppers.
>
>> I'd really like to get the netcdf mangling fixed, but haven't had the time to  figure out the git magic to create a patch for 5.x based on the fixes from 6.x.
>>
>
> That's one of the show stoppers. I agree with Dave Gobbi that an old
> school diff/patch approach should be good enough.
-------------- next part --------------
commit 644fe65cd9b81b79297918ce374ae2c43e93b766
Author: Sean McBride <sean at rogue-research.com>
Date:   Fri Aug 24 19:34:54 2012 -0400

    COMP: fixed bug #13372, compile error with isnan

    Change-Id: I5fbdfeecbccc44525f55b12386fdc9be7b126942

commit 7f08be80c60f3ab761155fd03a91077aa6b22ef0
Author: David Adair <adair.david at gmail.com>
Date:   Thu Aug 30 09:36:04 2012 -0600

    BUG: InteractorStyleImage not getting image for Window/Level.

    If an observer has not been set for the StartWindowLevelEvent, then
    the vtkInteractorStyleImage is supposed to automatically locate the
    last vtkImageActor or vtkImageSlice that was added to the renderer,
    and apply the window/level to that actor.  However, there was a bug
    where if a non-image actor was added to the renderer after the image
    actor, the image actor would not be found.  This patch fixes that bug.

    Backport of 022d847a from master to release.

    Change-Id: I58baac006ffe66ef367e196c10f98e60ee6e270e

commit 11f29ff94a14f626ef2022067e1183d27cc1e4e9
Author: Sean McBride <sean at rogue-research.com>
Date:   Thu Aug 30 10:30:13 2012 -0600

    COMP: removed C++11-style comma at end of enum declaration

    Backport of 5f5cc9f0 from master to release.

    Change-Id: I6616ace49b2d6589a4894945258145f45880f58f

commit 5eccfa3f875f60308ec242728a9612767c6d2434
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Thu Aug 30 10:35:09 2012 -0600

    BUG 13312: Fix crash on vtkImageProperty DeepCopy with LUT.

    If DeepCopy was used to copy a vtkImageProperty with a LookupTable into
    a vtkImageProperty without a LookupTable, a segmentation fault occurred.

    Backport of 316062ca from master to release.

    Change-Id: I1039fd8c9109b9005ae9038b0404c103c141079a

commit e14d5b2b09a06e8805104252814db8a5dbbfbbe7
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Thu Aug 30 10:39:59 2012 -0600

    COMP: Silence messages from vtkhdf5.

    The hdf5 CMakeLists.txt files give status messages every time
    it is read, even if there are no config errors or config changes.

    Backport of 9ecd9724 from master to release.

    Change-Id: Ie4c9be3fdef2111d941b2924f22754e1f025e3a7

commit d62bb3bd31918bf9e2b61700fa873d1fcb00ec86
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Thu Aug 30 10:47:06 2012 -0600

    BUG: Fix InsertAndMergeExtent bug introduced in earlier commit.

    Fix a bug that could cause delete [] to be called on an unallocated
    pointer.  This bug was introduced in a945dc69, prior to VTK 5.10.

    Backport of db0edf0a from master to release.

    Change-Id: I3e0d5b432d43aed43b3bd2fe755d40d7f1c0b90e

commit 9d9f5967d7f145621ccf69df12bc3f150fb8b065
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Thu Apr 12 11:59:18 2012 -0600

    COMP: No buffer lookahead space for wrapper-parser include directives.

    The wrapper's C++ preprocessor has its own code for parsing header
    files.  Its file buffer did not have any reserve for lookahead chars.
    Lookahead is done whenever a backslash appears in the file, so when
    a backslash was the last character in the buffer, an invalid read
    occurred.  This patch reserves two chars at the end of the buffer
    for lookahead.

    Backport of 8977cc9c from master to release.

    Change-Id: If31871f74ae826365109fb80fa3d643b57b10c4d

commit b6146cd9d9ff692b4e1117c12a59d8e36cdcf56e
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Wed Apr 25 01:40:10 2012 -0600

    COMP: Fix buffer lookahead for wrapper-parser include directive.

    Commit 8977cc9c did not properly handle the 2-character lookahead
    required for handling backslashes while preprocessing included files.
    It would sometimes duplicate the character following the backslash.

    Backport of fd79beff from master to release.

    Change-Id: I554c2adf507989364b49b2732dea8388190f35f1

commit 08ab47d633b6a96058bc488c90a586e32970d0b7
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Fri Jun 22 10:55:23 2012 -0600

    COMP: Fix segfault in vtkWrapJava on underscores in method names.

    On OS X 10.5, PowerPC, it was reported that vtkWrapJava crashed
    on some input files, and a stack trace identified a strncat call
    in part of the code that is meant to handle method names that
    contain underscores.  I could not reproduce the problem on my
    system (not even by adding asserts to guard against overflows),
    so I have re-written the code to eliminate strcat and strchr.

    Backport of 4ee34ca5 from master to release.

    Change-Id: I50d7b861b86ab185eae9b5acd5b9644cabb7bcf5

commit 299705b1618be42b835178a4cb4ec17212fcb22d
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Thu Aug 30 11:30:46 2012 -0600

    Fix export visibility for vtkImageStencilIterator

    Backport of d979cfa1 from master to release.

    Change-Id: I55b3804af01f3fdac320869ae2c316538f1dd4d2

commit 0a0b43ed9a514a2886b5d70a9af5d175027e9c5c
Author: Clinton Stimpson <clinton at elemtech.com>
Date:   Fri Jun 1 14:06:14 2012 -0600

    Fix QVTKWidget problem on Windows with Aero off.

    Need to invalidate the whole region at the start of WM_PAINT so the
    desktop compositor will composite the whole area.

    Change-Id: Id659f35ecbac16466d7ff68603607dff2d40c50e

commit 0ac9e89289805f3407ca1d0f322acc428bb623d9
Author: Dave DeMarle <dave.demarle at kitware.com>
Date:   Wed Sep 26 10:59:49 2012 -0400

    increase git size limit for netcdf

    Change-Id: I1a266fa2d511315f636bace749bdc8d804483a35

commit 24ea248bfb496921d36bf8570089a4a2e6a43a8b
Author: Dave DeMarle <dave.demarle at kitware.com>
Date:   Wed Sep 26 11:04:19 2012 -0400

    backport netcdf mangling fix from pre 6.0 master to 5.10.1 release

    Specifically:
    git diff 05ce589bb 4d08e39dd > patch
    apply that to release branch and merge in

    Change-Id: Icac2fc5d22bf0419b6862a40899d27fd5cad9310

commit f27a4ba654c720b69ab21f6d7f845e848da2da04
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Wed Sep 26 09:26:42 2012 -0600

    BUG 13443: Fix crash when vtkMath.h is wrapped on FreeBSD.

    The isinf() and isnan() macros on FreeBSD are defined in terms of
    the isinf() and isnan() library functions.  A macro expansion bug
    in the VTK 5.10 wrappers caused these macros to expand recursively,
    resulting in a segfault in the wrapper tools.  The macro expansion
    bug is fixed in VTK 6, but VTK 5.10 requires the vtkMath IsNan()
    and IsInf() inline definitions to be blocked.

    Change-Id: Ifc4ce554fd7273367f3fa6c6dad3b26dfa7871d4

commit 376579aa6782f24615e1c8a0ddf78aa93c4121f5
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Wed Sep 12 09:37:16 2012 -0600

    BUG 13198: Newer Tcl/Tk packages need static_cast with ckalloc.

    The ckalloc() function that Tcl uses for memory allocation has
    been changed in Tcl 8.6 to return "void *" instead of "char *".

    Change-Id: I7a09bd1e247748c4f4b4b017ca26f1cc8130463d

commit fe800da32f0393920906466801df8980f35e25de
Author: Dave DeMarle <dave.demarle at kitware.com>
Date:   Wed Sep 26 14:09:03 2012 -0400

    changes to build system to make it work in vtk5

    Change-Id: Id8cfdf9587d58b1fca13a715d40c8dd838be7070

commit bfff6943191ad14314e8005592d0df67ce370ba9
Author: Félix C. Morency <felix.c.morency at usherbrooke.ca>
Date:   Mon Jul 9 12:00:35 2012 -0400

    BUG: Fix GLXBadDrawable when using multiple QVTKRenderWindowInteractor

    The vtkRenderWindow was never finalized which caused GLXBadDrawable
    errors on application exit if using multiple QVTKRenderWindowInteractor.
    This patch provides a cleanup mechanism to finalize the vtkRenderWindow
    before its destruction/close preventing GLXBadDrawable errors. This
    patch works in both embedded and non-embedded cases.

    This patch also provides a test case for QVTKRenderWindowInteractor.

    DDM: commit manufactured to force dashboard tests

    Change-Id: Ie86d17fe7648868f8f1d5e4b00f52419d5f35a5b

commit 9c546b25ecad9dbf2bea0dfe3ed00304d7e6d014
Author: David Gobbi <david.gobbi at gmail.com>
Date:   Wed Aug 22 07:57:07 2012 -0600

    Make the QVTKRenderWindowInteractor more widely compatible.

    Fix compatibility issues with recent commit 5316dff1.  It used the new
    "import as" syntax that isn't supported on python 2.5 and earlier.
    It also used a new signal/slot mechanism that is only available in
    PyQt 4.5 and later, even though the old signal/slot mechanism was
    still being used elsewhere in the file (mixing old and new ways
    of doing the same thing in a single file makes the code hard to read).

    The test TestQVTKRenderWindowInteractor.py did not draw anything,
    because it didn't connect the renderer to the render window, nor
    did it initialize the interactor.  It also used two-space indentation
    in some places and four-space indentation in others.

    Change-Id: Ie41798554cce2d1ffe5705ec198d191d9e18cb08

commit 293d1afe8124cbf3f03f60cab5b5240d5e39b149
Author: Dave DeMarle <dave.demarle at kitware.com>
Date:   Wed Oct 3 08:55:33 2012 -0400

    Increment version to VTK 5.10.1

    Change-Id: I88eaf5afaaa9e723c54db0caf1920fe1ca3d011a