[vtk-developers] Consistent use of Pi in the toolkit

[Bill Lorensen]

Folks,

After 8 gerrit patches, I just merged a topic
http://review.source.kitware.com/#/t/633/
1) vtkMath::Pi now returns double.
2) vtkMath::TwoPi() is replaced with 2.0 * vtkMath::Pi().
2) Remove vtkMath::DoublePi and vtkMath::DoubleTwoPi and mark them as
deprecated.
3) Replace explicit use of 3.1415... and 6.28... with the vtkMath
constants.

You can see an analysis of the process here:
http://itk.org/Wiki/VTK/VTK6/Migration/DoublePrecisionPi

As part of this conversion, I activated a few hundred tcl tests to
make sure we could catch regressions (tcl tests represent over 20% of
VTK's test coverage).

I'll monitor the dashboard for any surprises.

Special thanks to David Gobbi for his valuable reviews during the
gerrit review process.

Bill

-- 
Unpaid intern in BillsBasement at noware dot com