[vtk-developers] [VTK 0012973]: The vtkMath::Pi() method should return double, not float, in VTK 6.0.

Mantis Bug Tracker mantis at public.kitware.com
Thu Mar 1 11:57:14 EST 2012


The following issue has been SUBMITTED. 
====================================================================== 
http://www.vtk.org/Bug/view.php?id=12973 
====================================================================== 
Reported By:                David Gobbi
Assigned To:                David Gobbi
====================================================================== 
Project:                    VTK
Issue ID:                   12973
Category:                   (No Category)
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     tabled
Project:                    Release 
Type:                       incorrect functionality 
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             2012-03-01 09:57 MST
Last Modified:              2012-03-01 09:57 MST
====================================================================== 
Summary:                    The vtkMath::Pi() method should return double, not
float, in VTK 6.0.
Description: 
I found 62 classes that call vtkMath::Pi().  Only one of them,
vtkExodusReader, seemed to have a reason for using a single-precision
value.  The others should be taking advantage of the extra precision of a
double-precision Pi value, but for some reason they aren't calling
vtkMath::DoublePi().

Rather than change all these classes so that they call vtkMath::DoublePi(), it
makes more sense for vtkMath::Pi() to return a double, and to deprecate
vtkMath::DoublePi().  Considering how close VTK 5.10 is to release, it is
probably best if this change is delayed until VTK 6.0.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-03-01 09:57 David Gobbi    New Issue                                    
2012-03-01 09:57 David Gobbi    Status                   backlog => tabled   
2012-03-01 09:57 David Gobbi    Assigned To               => David Gobbi     
======================================================================




More information about the vtk-developers mailing list