[vtk-developers] Need variable VTK_USE_FONTCONFIG?

[Utkarsh Ayachit]

I think in that case the real solution is to create a "new module"
that gets built, or not, not based on FONTCONFIG is found/enabled, or
not.

Utkarsh

On Mon, Jul 30, 2012 at 11:18 AM, Pat Marion <pat.marion at kitware.com> wrote:
> Utkarsh- yes, I think you are right.  But this change doesn't introduce the
> behavior.  This change just adds a variable for a user to disable
> fontconfig, previously, the decision to enable fontconfig was based on
> whether or not it is installed (FONTCONFIG_FOUND)
>
> Pat
>
>
> On Mon, Jul 30, 2012 at 12:56 PM, Berk Geveci <berk.geveci at kitware.com>
> wrote:
>>
>> Is the main issue the fact that it doesn't compile everywhere?
>>
>>
>> On Mon, Jul 30, 2012 at 12:36 PM, Utkarsh Ayachit
>> <utkarsh.ayachit at kitware.com> wrote:
>>>
>>> Is that an acceptable change? Looks like this will change the way the
>>> module is built based on some flag. I thought that was against the
>>> policy, isnt' it?
>>>
>>> Utkarsh
>>>
>>> On Mon, Jul 30, 2012 at 8:16 AM, Pat Marion <pat.marion at kitware.com>
>>> wrote:
>>> > Looks good to me.  I added a follow up commit that adds an error
>>> > message
>>> > when VTK_USE_FONTCONFIG is enabled but FontConfig is not found:
>>> >
>>> > http://review.source.kitware.com/#/t/982/
>>> >
>>> > Pat
>>> >
>>> >
>>> > On Mon, Jul 30, 2012 at 9:13 AM, David Lonie <david.lonie at kitware.com>
>>> > wrote:
>>> >>
>>> >> Hi Pat,
>>> >>
>>> >> On Thu, Jul 26, 2012 at 10:49 PM, Pat Marion <pat.marion at kitware.com>
>>> >> wrote:
>>> >> > I noticed that a fontconfig support was recently added to
>>> >> > Rendering/FreeType
>>> >> > module.  This looks like a really useful feature!  For users who
>>> >> > wish to
>>> >> > avoid the dependency, I think there should be a VTK_USE_FONTCONFIG
>>> >> > option,
>>> >> > allowing fontconfig to be disabled.  Currently,
>>> >> > Rendering/FreeType/CMakeLists.txt uses fontconfig when
>>> >> > FONTCONFIG_FOUND
>>> >> > is
>>> >> > true.
>>> >>
>>> >> Sorry for the late reply -- will this work for you?
>>> >>
>>> >> http://review.source.kitware.com/#/c/6637/
>>> >>
>>> >> Dave
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > Powered by www.kitware.com
>>> >
>>> > Visit other Kitware open-source projects at
>>> > http://www.kitware.com/opensource/opensource.html
>>> >
>>> > Follow this link to subscribe/unsubscribe:
>>> > http://www.vtk.org/mailman/listinfo/vtk-developers
>>> >
>>> >
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>
>