[vtk-developers] Glyph3DMapper valgrind defects

[David Lonie]

Hi Bill,

Thanks for catching these issues -- I've corrected both here:
http://review.source.kitware.com/4335

Cheers,
Dave

On Sun, Feb 19, 2012 at 11:36 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> David,
>
> The Glyph3DMapper is causing several valgrind defects.
> http://open.cdash.org/viewDynamicAnalysis.php?buildid=2018651
>
> These are because UseSelectionIds is not initialized in the constructor.
> Either
>  this->UseSelectionIds = false;
> or
>  this->UseSelectionIds = true;
> should be present in the constructor. I would have made the change,
> but I don't know the intended default.
>
> Also, the documentation for is incorrect. Looks like a copy/paste error.
>  vtkSetMacro(UseSelectionIds, bool);
>  vtkBooleanMacro(UseSelectionIds, bool);
>  vtkGetMacro(UseSelectionIds, bool);
>
> Thanks,
>
> Bill
> --
> Unpaid intern in BillsBasement at noware dot com