[vtk-developers] Debug leaks, dashboards and local behavior

[Marcus D. Hanwell]

On Mon, Feb 13, 2012 at 11:55 AM, David Cole <david.cole at kitware.com> wrote:
> On Mon, Feb 13, 2012 at 11:46 AM, Marcus D. Hanwell
> <marcus.hanwell at kitware.com> wrote:
>> Exporting either of those variables will then cause the test to fail
>> locally. If there is a good reason to do this, wouldn't it be better
>> to pass if the user explicitly exported a variable,
>> I_KNOW_I_TURNED_ON_DEBUG_LEAKS_BUT_I_STILL_WANT_TESTS_TO_PASS or
>> similar?
>>
> There's no need to pass the tests when there are memory leaks. That only
> encourages memory leaks, and enables people to ignore them.
>
> Get rid of them (mem leaks that is). If you don't like it, then build with
> mem leak detection turned off entirely.

The variable name was mostly tongue in cheek as I am not sure I see
the use case for even having this there. The code change is extremely
minimal, and if you turned on debug leaks I would assume you expect to
see if fail in the tests if there is a leak.

Marcus