[vtk-developers] Need a client side hook for trailing whitespace

[Bill Lorensen]

I should have said on gerrit. And going forward, we should definitely
consider fixing it for VTK6.

On Thu, Feb 9, 2012 at 12:06 PM, Berk Geveci <berk.geveci at kitware.com> wrote:
> I am sorry but consensus among whom? There were several long discussions on
> the developers list about trailing whitespaces and no consensus was reached
> in any of them. If there is a strong consensus among VTK developers, that's
> fine but honestly this would be at the bottom of my priority list.
>
> -berk
>
> On Thu, Feb 9, 2012 at 11:57 AM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>>
>> The consensus is to restore the client side hook for trailing white
>> space. But rather than an error, it will be a warning. This will
>> permit developers to avoid the warning on gerrit.
>> See the gerrit topic: http://review.source.kitware.com/#/c/4219/
>> For VTK6, the warning will become an error. The VTK6 team will run a
>> script to cleanup existing code.
>>
>>
>> On Tue, Feb 7, 2012 at 9:36 AM, Marcus D. Hanwell
>> <marcus.hanwell at kitware.com> wrote:
>> > On Mon, Feb 6, 2012 at 3:43 PM, Bill Lorensen <bill.lorensen at gmail.com>
>> > wrote:
>> >> Now that we are using gerrit for vtk changes, I think we need a
>> >> trailing whitespace pre-commit hook. Currently this is caught by
>> >> gerrit, but a developer does not see the defect on local commits.
>> >>
>> > This mail gives a summary, we turned it off,
>> >
>> > http://www.vtk.org/pipermail/vtk-developers/2011-April/009638.html
>> >
>> > This is largely the reason for making it a warning in Gerrit (not an
>> > error). I would like to turn it back on (by adjusting .gitattributes
>> > in VTK) and leave it on as a warning in the Gerrit content check
>> > robot. That way, if there is good reason, the --no-verify argument can
>> > be used to bypass the local hooks.
>> >
>> > The complicating factor there is that this would also bypass the
>> > Gerrit Change-Id hook, this is probably acceptable for those few cases
>> > where you need to push through commits with whitespace issues but
>> > perhaps too far for some? The checks only ever concerned new changes,
>> > and would continue to do so.
>> >
>> > Marcus
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>



-- 
Unpaid intern in BillsBasement at noware dot com