[vtk-developers] ANN: VTK moving to topic reviews in Gerrit on Wednesday

[Brad King]

On 2/1/2012 4:42 PM, Bill Lorensen wrote:
> The robot content checks report very quickly. Are you sure they are doing something?
>
> I just submitted this patch:
> http://review.source.kitware.com/#/c/3511/
> and the reponse was very fast.

That is not the auto builds.  That is the server-side content checks
that used to be done by the topic stage to reject pushes.  Now in Gerrit
a commit that would have been rejected by the topic stage can now be
pushed but the robot will immediately respond with a failure message
and the Verified flag will be set to -1 so it cannot be merged.

This is documented in the new workflow instructions.  See the bottom
of the "Share a Topic" section:

   http://www.vtk.org/Wiki/VTK/Git/Develop#Share_a_Topic

The auto builds will add notes for reference by human reviewers before
approval.

-Brad