[vtk-developers] VTK 5.10 build error on mac

[Sean McBride]

On Fri, 17 Aug 2012 15:04:52 +0200, Fetzer, Andreas said:

>thank you for your answer. I already tried inserting std:: in front of
>isnan() and it worked. The VTK build then finished without any more errors. 

The problem with that solution is that std::isnan is new in C++11, and VTK cannot assume C++11.

>What is weird is that this error does not appear on the VTK dashboard
>even though there are also Mac OS X 10.7 machines compiling with clang.

The file vtkQtBarChart.cxx seems to be gone in git master (VTK 6), and it seems like none of the 5.x builds use clang, and probably not VTK_USE_QTCHARTS and VTK_USE_QT either.

>That is why I wanted to ask if this is a known issue to VTK and whether
>there will be a fix.

The fix I would suggest is for vtkQtBarChart.cxx to use vtkMath::IsNan() instead of isnan() directly.

Kitware folks: how can one create a patch for the 5.x branch?  Like so?

git checkout -b my-topic origin/release

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada