[vtk-developers] Patch for vtkCocoaRenderWindowInteractor TerminateApp behavior

[Pat Marion]

Replacing the class in PCL is one option, another option is that it may be
possible to override just the Start() method by registering an observer to
StartEvent.

Radu, since PCL builds against VTK 5.x, PCL will need a override/workaround
for some time into the future I suppose.

Pat

On Tue, Aug 7, 2012 at 1:58 PM, Radu B. Rusu <radu.b.rusu at gmail.com> wrote:

> That's fantastic, thanks to everyone for their work!
>
> Pat and I discussed that as a workaround until VTK updates would be to
> bring in a copy of the new Cocoa interactor class in PCL and #ifdef it for
> Mac, so that we can fix the outstanding issues we have at the moment in
> PCL. Once VTK updates, we can remove the class (it will be internal anyway).
>
> Cheers,
> Radu.
> --
> http://openperception.org
>
>
> On 08/07/2012 10:54 AM, Marcus D. Hanwell wrote:
>
>> On Tue, Aug 7, 2012 at 1:50 PM, Sean McBride <sean at rogue-research.com>
>> wrote:
>>
>>> On Fri, 3 Aug 2012 19:11:55 -0400, Pat Marion said:
>>>
>>>  Anyway, I appreciate you taking the time to look over the patch details!
>>>> If we decide to proceed with the patch, you said some more changes
>>>> might be
>>>> needed, any hints what those might be?
>>>>
>>>
>>> Sorry for not elaborating, I was just leaving work when I wrote that.
>>>  And now I'm off on vacation for two weeks.  :(
>>>
>>> I don't object to you committing this as is for now.  When I get back, I
>>> can expand on your change.  Basically, from what you're saying we don't
>>> need any of that code that terminates the process, ever. Also, we should
>>> review when we register/unregister for window closing notifications.
>>>  Currently the start and stop methods are not very symmetric, IIRC.
>>>
>>> If you do commit, I suggest you update the doxy comments for
>>> TerminateApp() at the same time.
>>>
>>>  I think ideally we should add new API to more cleanly accomplish a
>> process events call, but as the other implementations all behave in a
>> certain way consistency seems reasonable. I talked with Radu in the
>> past about what they were doing, and how it was not necessarily the
>> intended behavior of those functions (but it did work for them).
>>
>> If people are happy with the change, it seems like this will help out
>> a set of VTK users without impacting other projects.
>>
>> Marcus
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20120807/ef2fcae7/attachment.html>