[vtk-developers] Why do we need the VTK_WRAP_HIERARCHY_EXE variable.

Utkarsh Ayachit utkarsh.ayachit at kitware.com
Mon Aug 6 14:58:39 EDT 2012


I've pushed a topic to gerrit to resolve this issue:
http://review.source.kitware.com/#/t/1028/

Utkarsh

On Sat, Aug 4, 2012 at 10:16 PM, Utkarsh Ayachit
<utkarsh.ayachit at kitware.com> wrote:
> Perfect! That helps. I'll make a pass an clean up such VTK_...._EXE
> variables.I push it to gerrit for review.
>
> Utkarsh
>
> On Sat, Aug 4, 2012 at 9:59 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>> Probably just an oversight.  In vtkWrapPython.cmake, the following code is used:
>>
>>   if(NOT VTK_WRAP_PYTHON_EXE)
>>     if(TARGET vtkWrapPython)
>>       set(VTK_WRAP_PYTHON_EXE vtkWrapPython)
>>     else()
>>       message(SEND_ERROR
>>         "VTK_WRAP_PYTHON_EXE not specified when calling VTK_WRAP_PYTHON3")
>>     endif()
>>   endif()
>>
>> The same could be done for VTK_WRAP_HIERARCHY_EXE in
>> vtkWrapHierarchy.cmake and for VTK_WRAP_PYTHON_INIT_EXE in
>> vtkPythonWrapping.cmake.
>>
>>  - David
>>
>>
>> On Sat, Aug 4, 2012 at 6:53 PM, Utkarsh Ayachit
>> <utkarsh.ayachit at kitware.com> wrote:
>>> Same issue with VTK_WRAP_PYTHON_INIT_EXE (in vtkPythonWrapping.cmake).
>>> Why aren't we directly referring to the corresponding target?
>>>
>>> Utkarsh
>>>
>>> On Sat, Aug 4, 2012 at 8:51 PM, Utkarsh Ayachit
>>> <utkarsh.ayachit at kitware.com> wrote:
>>>> In vtkWrapHierarchy.cmake, why is the VTK_WRAP_HIERARCHY_EXE variable
>>>> needed/used? Why can't we simply refer to the target
>>>> vtkWrapHieararchy? Since the target is exported in VTKTarget.cmake,
>>>> it's makes it easier for external projects depending on CMake to use
>>>> the vtkWrapHierarchy.cmake as needed.
>>>>
>>>> Utkarsh
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>



More information about the vtk-developers mailing list