[vtk-developers] OS X vtkDetermineCompilerFlags.cmake broken for gcc 4.5 up -mlong-branch only relevant to PPC

[David Cole]

Some files probably included some system headers that had "\p" strings in
them...

Not sure if it's true anymore.


On Fri, Apr 13, 2012 at 2:58 PM, Kent Williams <nkwmailinglists at gmail.com>wrote:

> Another flag issue: -fpascal-strings -- another Apple-built-gcc-only flag.
>
> This would be needed to support pascal strings for old API calls, i.e.
> strings like this:
>
> "\pthis is a pascal string"
>
> I didn't see any Pascal Strings in any of the ftgl files.
>
> diff --git a/Utilities/ftgl/CMakeLists.txt b/Utilities/ftgl/CMakeLists.txt
> index 8f8e37d..edcaa23 100644
> --- a/Utilities/ftgl/CMakeLists.txt
> +++ b/Utilities/ftgl/CMakeLists.txt
> @@ -117,7 +117,7 @@ ENDIF (UNIX)
>  #
>  IF (APPLE)
>   IF(CMAKE_COMPILER_IS_GNUCXX)
> -    SET (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated
> -fpascal-strings")
> +    SET (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated")
>   ENDIF(CMAKE_COMPILER_IS_GNUCXX)
>  ENDIF (APPLE)
>
>
>
> On Fri, Apr 13, 2012 at 1:16 PM, Sean McBride <sean at rogue-research.com>
> wrote:
> >>Shouldn't it be something like this?
> >>
> >>set(BUILDING_ON_PPC_OS_X  <whatever flag(s) tell you you're building
> >>on OS X with PPC>)
> >>if(NOT BUILD_SHARED_LIBS AND ${BUILDING_ON_PPC_OS_X})
> >
> > Whether you're building _on_ PPC is not important, it's whether your
> building _for_ the PPC architecture.  Remember, with Universal Binaries you
> may be building for ppc & intel at the same time.
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20120413/55b1394e/attachment.html>