[vtk-developers] dashboard failure with Java wrapping and Obj-C++?

[Chris Harris]

Looks goods to me.

Chris

On Wed, Apr 11, 2012 at 4:59 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> Just pushed it a few seconds ago.  Adding ".mm" worked like a charm.
>
> On Wed, Apr 11, 2012 at 2:58 PM, Chris Harris <chris.harris at kitware.com> wrote:
>> David,
>>
>> That sounds like a good fix to me. Are you going to push a patch? If
>> not I am happy to do so.
>>
>> Regards,
>>
>> Chris
>>
>> On Wed, Apr 11, 2012 at 4:01 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>>> On Wed, Apr 11, 2012 at 1:46 PM, Sean McBride <sean at rogue-research.com> wrote:
>>>> On Wed, 11 Apr 2012 13:40:39 -0600, David Gobbi said:
>>>>
>>>>>The fix would probably be along the lines of:
>>>>>
>>>>>1)  In Rendering/Core/CMakeLists.txt,
>>>>>define a new file property WRAP_JAVA_OBJC:
>>>>>
>>>>>set_source_files_properties(
>>>>>  vtkRenderWindow.cxx
>>>>>  PROPERTIES WRAP_JAVA_OBJC 1
>>>>>)
>>>>>
>>>>>2) in CMake/vtkJavaWrapping.cmake,
>>>>>check whether WRAP_JAVA_OBJC is set for each source file,
>>>>>and if so add "-ObjC++" for the corresponding Java.cxx file.
>>>>>
>>>>>Alternatively, a special case for vtkRenderWindowJava.cxx could be
>>>>>hard-coded into vtkJavaWrapping.cmake, rather than defining a new
>>>>>property that only applies to a single file in all of VTK.
>>>>
>>>> This file doesn't exist in git, it's created, right?
>>>>
>>>> Is there no way to give the file a .mm extension instead of .cxx?
>>>
>>> Yes, vtkWrapJava.cmake could check the file properties and
>>> generate the file name with a .mm instead of with a .cxx, and
>>> that would be even easier than adding the -ObjC++ flag.
>>>
>>>  - David
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>