[vtk-developers] git trailing whitespace check and 3rd party code

[Sean McBride]

On Tue, 18 Oct 2011 19:28:37 -0400, Brad King said:

>On 10/18/2011 6:10 PM, Sean McBride wrote:
>> I'm updating freetype in VTK from 2.4.4 to 2.4.7, but am running
>> afoul of the git hook that checks for trailing whitespace.
>> 
>> Can this be disabled for all 3rd party code in VTK?
>
>What files are rejected?  That check is disabled for most
>source file types in VTK already:
>
> http://vtk.org/gitweb?p=VTK.git;a=blob;f=.gitattributes;hb=HEAD
>
>Note the "-blank-at-eol" value in the whitespace attributes.

Brad,

Thanks for the reply.  Didn't know about .gitattributes...

The exact output is:

leprechaun:VTK sean$ git commit -a -m "updated freetype from 2.4.4 to 2.4.7"
pre-commit hook failure
-----------------------

Utilities/vtkfreetype/ChangeLog:126: trailing whitespace.
+	constructed correctly.  It's even less than that, see e.g. 
Utilities/vtkfreetype/ChangeLog.23:753: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1347: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1350: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1354: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1360: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1364: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1375: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1382: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1386: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1390: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1393: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1656: trailing whitespace.
+	* src/cff/cffgload.c (cff_slot_load): The types of	
Utilities/vtkfreetype/ChangeLog.23:1814: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1817: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1822: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1825: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1828: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1831: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1834: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1837: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1842: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1845: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1848: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1851: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1854: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1857: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1863: trailing whitespace.
+	
Utilities/vtkfreetype/ChangeLog.23:1979: trailing whitespace.
+	http://lists.gnu.org/archive/html/freetype-devel/2009-07/msg00002.html	
Utilities/vtkfreetype/ChangeLog.23:2817: space before tab in indent.
+ 	basepic.h to access them.
Utilities/vtkfreetype/src/gzip/infblock.c:386: new blank line at EOF.
Utilities/vtkfreetype/src/gzip/inflate.c:273: new blank line at EOF.
Utilities/vtkfreetype/src/pcf/README:36: trailing whitespace.
+The driver always exports `ft_encoding_none' as face->charmap.encoding. 

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada