[vtk-developers] BUILD_SHARED_LIBS CMake help text

[Pebay, Philippe P]

David,

I do not remember exactly why this happened when (2007) we integrated Verdict in VTK, it is possible that David Thompson does. David T. please chime in if you do remember. Thanks.

Now, what I see is that the value of BUILD_SHARED_LIBS is checked in multiple CMakeLists.txt, but I can't understand why it is defined as an option() in verdict/CMakeLists.txt. That does not seem to make any sense at all.

Philippe


--
Philippe Pébay
Sandia National Laboratories

________________________________________
From: David Doria [daviddoria at gmail.com]
Sent: Tuesday, May 10, 2011 1:27 PM
To: Pebay, Philippe P
Cc: VTK Developers
Subject: Re: [vtk-developers] BUILD_SHARED_LIBS CMake help text

On Tue, May 10, 2011 at 4:02 PM, Pebay, Philippe P <pppebay at sandia.gov> wrote:
> Yes, this seems like a typo in the documentation.

Hm, the variable seems to be defined in:

VTK/Utilities/verdict/CMakeLists.txt:
option(BUILD_SHARED_LIBS "Build Verdict with shared libraries." OFF)

Should this line be moved up to

VTK/CMakeLists.txt
option(BUILD_SHARED_LIBS "Build VTK with shared libraries." OFF)
?

Also, there seems to be a

VTK_BUILD_SHARED_LIBS

preprocessor definition that gets set to the value of
BUILD_SHARED_LIBS by CMake/vtkSelectSharedLibraries.cmake . Why don't
the c++ files just check #ifdef BUILD_SHARED_LIBS directly?

David