[vtk-developers] ParaView HDF5 migration to VTK

[David Partyka]

Sorry, I had forgotten about this. Do you mind reporting a bug and assigning
it to me. I'll try and get it done in the next few days. We have a macro
that does this kind of testing in CMake\vtkCheckCXXAcceptsFlags.cmake that I
can either call in the vtkhdf5 code or adapt it slightly to make the changes
to vtkhdf5 minimal.

Thanks!

On Wed, Mar 9, 2011 at 11:19 AM, Sean McBride <sean at rogue-research.com>wrote:

> David,
>
> Any news on no longer blindly adding the -std=c99 flag?
>
> Sean
>
>
> On Wed, 2 Feb 2011 18:38:22 -0500, David Partyka said:
>
> >Though the comment is exactly rigth, those should be compiler checks and
> not
> >just near blindly appended to CMAKE_C_FLAGS.
> >
> >On Wed, Feb 2, 2011 at 6:33 PM, David Partyka
> ><david.partyka at kitware.com>wrote:
> >
> >> I will fix the install rule. Is there a good CMake way to detect clang?
> Id
> >> prefer to make any fix as invasive as possible to minimize deviating
> from
> >> upstream.
> >>
> >>
> >> On Wed, Feb 2, 2011 at 6:27 PM, Sean McBride <sean at rogue-
> research.com>wrote:
> >>
> >>> On Mon, 20 Dec 2010 15:54:50 -0500, Dave Partyka said:
> >>>
> >>> >I have just merged commits to VTK and ParaView that move ParaView's
> HDF5
> >>> >into VTK. This migration makes it possible for VTK developers to begin
> >>> using
> >>> >HDF5 storage in their own VTK classes and will also allow us to enable
> >>> HDF5
> >>> >functionality in other Utilities (such as HDF5 enabled NetCDF). HDF5
> is
> >>> >located under Utilities/vtkhdf5. This version of HDF5 is the same that
> >>> was
> >>> >in ParaView (1.8.5) but now is also mangled with vtk as a prefix.
> >>> >
> >>> >I strongly recommend that ParaView developers do a clean build after
> >>> pulling
> >>> >these changes to reduce the likelihood of build failures. We will be
> >>> >watching the dashboard carefully for the next few days. If anyone
> >>> >experiences any issues please feel free to let us know and/or report a
> >>> bug.
> >>>
> >>> Dave,
> >>>
> >>> 1) when installing vtk (master) most all .h files go into /include/
> >>> vtk-5.9, except a bunch of H5*.h files go directly into /include.  Is
> >>> that a bug?
> >>>
> >>> 2) Building vtk with clang reports:
> >>>
> >>> clang: warning: argument unused during compilation: '-std=c99'
> >>>
> >>> This appears to come from Utilities/vtkhdf5/CMakeLists.txt
> >>>
> >>>
> >>> #---------------------------------
> >--------------------------------------------
> >>> # Compiler specific flags : Shouldn't there be compiler tests for these
> >>>
> >>> #---------------------------------
> >--------------------------------------------
> >>> IF (NOT WIN32)
> >>>  SET (CMAKE_C_FLAGS "${CMAKE_ANSI_CFLAGS} ${CMAKE_C_FLAGS} -std=c99 -
> >>> fomit-frame-pointer -finline-functions -fno-common")
> >>> ENDIF (NOT WIN32)
> >>>
> >>> I believe the comment is correct. :)
> >>>
> >>> --
> >>> ____________________________________________________________
> >>> Sean McBride, B. Eng                 sean at rogue-research.com
> >>> Rogue Research                        www.rogue-research.com
> >>> Mac Software Developer              Montréal, Québec, Canada
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110309/e96877c8/attachment.html>